You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Zhe Zhang (JIRA)" <ji...@apache.org> on 2016/07/11 22:16:11 UTC

[jira] [Updated] (HDFS-10544) Balancer doesn't work with IPFailoverProxyProvider

     [ https://issues.apache.org/jira/browse/HDFS-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhe Zhang updated HDFS-10544:
-----------------------------
    Attachment: HDFS-10544.04.patch

Thanks [~shv] for the review! Updating the patch to address the comments.

bq. ... Not sure if this is what you expected.
I updated the test to set a config entry to map {{ns1}} to a physical URI. So the {{else}} statement in {{DFSUtil#getNameServiceUris}} will be able to resolve {{ns1}} to a physical URI. I think this is the correct configuration in an environment that uses {{IPFailoverProxyProvider}}.

Also updated the comments. Please kindly review.

> Balancer doesn't work with IPFailoverProxyProvider
> --------------------------------------------------
>
>                 Key: HDFS-10544
>                 URL: https://issues.apache.org/jira/browse/HDFS-10544
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Zhe Zhang
>            Assignee: Zhe Zhang
>         Attachments: HDFS-10544.00.patch, HDFS-10544.01.patch, HDFS-10544.02.patch, HDFS-10544.03.patch, HDFS-10544.04.patch
>
>
> Right now {{Balancer}} gets the NN URIs through {{DFSUtil#getNameServiceUris}}, which returns logical URIs in HA is enabled. If {{IPFailoverProxyProvider}} is used, {{Balancer}} will not be able to start.
> I think the bug is at {{DFSUtil#getNameServiceUris}}:
> {code}
>     for (String nsId : getNameServiceIds(conf)) {
>       if (HAUtil.isHAEnabled(conf, nsId)) {
>         // Add the logical URI of the nameservice.
>         try {
>           ret.add(new URI(HdfsConstants.HDFS_URI_SCHEME + "://" + nsId));
> {code}
> Then {{if}} clause should also consider if the {{FailoverProxyProvider}} has {{useLogicalURI}} enabled. If not, {{getNameServiceUris}} should try to resolve the physical URI for this nsId.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org