You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/01/07 04:58:17 UTC
[GitHub] [kafka] dengziming opened a new pull request #11655: KAFKA-13316; Enable KRaft mode in CreateTopics tests
dengziming opened a new pull request #11655:
URL: https://github.com/apache/kafka/pull/11655
*More detailed description of your change*
This PR follows #11629 to enable `CreateTopicsRequestWithForwardingTest` and `CreateTopicsRequestWithPolicyTest` in KRaft mode.
*Summary of testing strategy (including rationale)*
QA
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #11655: KAFKA-13316; Enable KRaft mode in CreateTopics tests
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #11655:
URL: https://github.com/apache/kafka/pull/11655#discussion_r802172051
##########
File path: core/src/test/scala/unit/kafka/server/CreateTopicsRequestWithPolicyTest.scala
##########
@@ -37,7 +38,8 @@ class CreateTopicsRequestWithPolicyTest extends AbstractCreateTopicsRequestTest
properties.put(KafkaConfig.CreateTopicPolicyClassNameProp, classOf[Policy].getName)
}
- @Test
+ @ParameterizedTest
+ @ValueSource(strings = Array("zk", "kraft"))
def testValidCreateTopicsRequests(): Unit = {
Review comment:
I think we need the "quorum" argument here and below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #11655: KAFKA-13316; Enable KRaft mode in CreateTopics tests
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #11655:
URL: https://github.com/apache/kafka/pull/11655#discussion_r802933225
##########
File path: core/src/test/scala/unit/kafka/server/CreateTopicsRequestWithPolicyTest.scala
##########
@@ -55,11 +63,9 @@ class CreateTopicsRequestWithPolicyTest extends AbstractCreateTopicsRequestTest
assignment = Map(0 -> List(1, 0), 1 -> List(0, 1))))))
}
- @Test
- def testErrorCreateTopicsRequests(): Unit = {
- val existingTopic = "existing-topic"
- createTopic(existingTopic, 1, 1)
Review comment:
Do we need to? Seems like the main thing we're testing here is the case when the topic already exists. Would it be just as good to create with the admin client and then verify the `TOPIC_ALREADY_EXISTS` error code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #11655: KAFKA-13316; Enable KRaft mode in CreateTopics tests
Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #11655:
URL: https://github.com/apache/kafka/pull/11655#issuecomment-1007141611
Hello @cmccabe , Please help review this, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on a change in pull request #11655: KAFKA-13316; Enable KRaft mode in CreateTopics tests
Posted by GitBox <gi...@apache.org>.
dengziming commented on a change in pull request #11655:
URL: https://github.com/apache/kafka/pull/11655#discussion_r802289648
##########
File path: core/src/test/scala/unit/kafka/server/CreateTopicsRequestWithPolicyTest.scala
##########
@@ -55,11 +63,9 @@ class CreateTopicsRequestWithPolicyTest extends AbstractCreateTopicsRequestTest
assignment = Map(0 -> List(1, 0), 1 -> List(0, 1))))))
}
- @Test
- def testErrorCreateTopicsRequests(): Unit = {
- val existingTopic = "existing-topic"
- createTopic(existingTopic, 1, 1)
Review comment:
We don't support creating topics directly by writing metadata-topic, so we can't test this case in kraft mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on a change in pull request #11655: KAFKA-13316; Enable KRaft mode in CreateTopics tests
Posted by GitBox <gi...@apache.org>.
dengziming commented on a change in pull request #11655:
URL: https://github.com/apache/kafka/pull/11655#discussion_r803251469
##########
File path: core/src/test/scala/unit/kafka/server/CreateTopicsRequestWithPolicyTest.scala
##########
@@ -55,11 +63,9 @@ class CreateTopicsRequestWithPolicyTest extends AbstractCreateTopicsRequestTest
assignment = Map(0 -> List(1, 0), 1 -> List(0, 1))))))
}
- @Test
- def testErrorCreateTopicsRequests(): Unit = {
- val existingTopic = "existing-topic"
- createTopic(existingTopic, 1, 1)
Review comment:
Thank you for pointing out this, firstly I think we are testing creating a topic that violates the policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #11655: KAFKA-13316; Enable KRaft mode in CreateTopics tests
Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #11655:
URL: https://github.com/apache/kafka/pull/11655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #11655: KAFKA-13316; Enable KRaft mode in CreateTopics tests
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #11655:
URL: https://github.com/apache/kafka/pull/11655#discussion_r802933225
##########
File path: core/src/test/scala/unit/kafka/server/CreateTopicsRequestWithPolicyTest.scala
##########
@@ -55,11 +63,9 @@ class CreateTopicsRequestWithPolicyTest extends AbstractCreateTopicsRequestTest
assignment = Map(0 -> List(1, 0), 1 -> List(0, 1))))))
}
- @Test
- def testErrorCreateTopicsRequests(): Unit = {
- val existingTopic = "existing-topic"
- createTopic(existingTopic, 1, 1)
Review comment:
Do we need to? Seems like the main thing we're testing here is the case when the topic already exists. Seems like it would be just as good to create with the admin client and then verify the `TOPIC_ALREADY_EXISTS` error code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org