You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Andreas Sahlbach (JIRA)" <ji...@apache.org> on 2010/02/16 14:01:27 UTC

[jira] Created: (CXF-2677) UriInfoImpl.getRequestUri() fails on URLs that require escaping

UriInfoImpl.getRequestUri() fails on URLs that require escaping
---------------------------------------------------------------

                 Key: CXF-2677
                 URL: https://issues.apache.org/jira/browse/CXF-2677
             Project: CXF
          Issue Type: Bug
          Components: JAX-RS
    Affects Versions: 2.2.6, 2.2.5
            Reporter: Andreas Sahlbach


current implementation from UriInfoImpl:
{code}
    public URI getRequestUri() {
        String path = getAbsolutePathAsString();
        String queries = (String)message.get(Message.QUERY_STRING);
        if (queries != null) {
            path += "?" + queries;
        }
        return URI.create(path);
    }
{code}
This fails for URIs that have characters that have to be escaped as of rfc2396. 

Examples: http://localhost:13080/services/rest/crypto/hash;algorithm=S{A/text/foo or http://localhost:13080/services/rest/crypto/hash;algorithm=S^A/text/foo
fail with Exception during getRequestUri() due to { or ^ as part of the uri


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CXF-2677) UriInfoImpl.getRequestUri() fails on URLs that require escaping

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-2677.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2.7
         Assignee: Sergey Beryozkin

> UriInfoImpl.getRequestUri() fails on URLs that require escaping
> ---------------------------------------------------------------
>
>                 Key: CXF-2677
>                 URL: https://issues.apache.org/jira/browse/CXF-2677
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 2.2.5, 2.2.6
>            Reporter: Andreas Sahlbach
>            Assignee: Sergey Beryozkin
>             Fix For: 2.2.7
>
>
> current implementation from UriInfoImpl:
> {code}
>     public URI getRequestUri() {
>         String path = getAbsolutePathAsString();
>         String queries = (String)message.get(Message.QUERY_STRING);
>         if (queries != null) {
>             path += "?" + queries;
>         }
>         return URI.create(path);
>     }
> {code}
> This fails for URIs that have characters that have to be escaped as of rfc2396. 
> Examples: http://localhost:13080/services/rest/crypto/hash;algorithm=S{A/text/foo or http://localhost:13080/services/rest/crypto/hash;algorithm=S^A/text/foo
> fail with Exception during getRequestUri() due to { or ^ as part of the uri

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CXF-2677) UriInfoImpl.getRequestUri() fails on URLs that require escaping

Posted by "Andreas Sahlbach (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834231#action_12834231 ] 

Andreas Sahlbach commented on CXF-2677:
---------------------------------------

Confirmed. Works for me now. 

Thanks for fixing bugs before I reported them. :-)

> UriInfoImpl.getRequestUri() fails on URLs that require escaping
> ---------------------------------------------------------------
>
>                 Key: CXF-2677
>                 URL: https://issues.apache.org/jira/browse/CXF-2677
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 2.2.5, 2.2.6
>            Reporter: Andreas Sahlbach
>
> current implementation from UriInfoImpl:
> {code}
>     public URI getRequestUri() {
>         String path = getAbsolutePathAsString();
>         String queries = (String)message.get(Message.QUERY_STRING);
>         if (queries != null) {
>             path += "?" + queries;
>         }
>         return URI.create(path);
>     }
> {code}
> This fails for URIs that have characters that have to be escaped as of rfc2396. 
> Examples: http://localhost:13080/services/rest/crypto/hash;algorithm=S{A/text/foo or http://localhost:13080/services/rest/crypto/hash;algorithm=S^A/text/foo
> fail with Exception during getRequestUri() due to { or ^ as part of the uri

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CXF-2677) UriInfoImpl.getRequestUri() fails on URLs that require escaping

Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834276#action_12834276 ] 

Sergey Beryozkin commented on CXF-2677:
---------------------------------------

> Confirmed. Works for me now. 

thanks

> Thanks for fixing bugs before I reported them. :-)

Another user created a similar issue few weeks ago :-)

cheers, Sergey

> UriInfoImpl.getRequestUri() fails on URLs that require escaping
> ---------------------------------------------------------------
>
>                 Key: CXF-2677
>                 URL: https://issues.apache.org/jira/browse/CXF-2677
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 2.2.5, 2.2.6
>            Reporter: Andreas Sahlbach
>            Assignee: Sergey Beryozkin
>             Fix For: 2.2.7
>
>
> current implementation from UriInfoImpl:
> {code}
>     public URI getRequestUri() {
>         String path = getAbsolutePathAsString();
>         String queries = (String)message.get(Message.QUERY_STRING);
>         if (queries != null) {
>             path += "?" + queries;
>         }
>         return URI.create(path);
>     }
> {code}
> This fails for URIs that have characters that have to be escaped as of rfc2396. 
> Examples: http://localhost:13080/services/rest/crypto/hash;algorithm=S{A/text/foo or http://localhost:13080/services/rest/crypto/hash;algorithm=S^A/text/foo
> fail with Exception during getRequestUri() due to { or ^ as part of the uri

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CXF-2677) UriInfoImpl.getRequestUri() fails on URLs that require escaping

Posted by "Andreas Sahlbach (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834195#action_12834195 ] 

Andreas Sahlbach commented on CXF-2677:
---------------------------------------

My Links got f*ck up due to the link parser of jira. Here they are again:
{noformat}
http://localhost:13080/services/rest/crypto/hash;algorithm=S{A/text/foo 
{noformat}
and 
{noformat}
http://localhost:13080/services/rest/crypto/hash;algorithm=S^A/text/foo
{noformat}

> UriInfoImpl.getRequestUri() fails on URLs that require escaping
> ---------------------------------------------------------------
>
>                 Key: CXF-2677
>                 URL: https://issues.apache.org/jira/browse/CXF-2677
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 2.2.5, 2.2.6
>            Reporter: Andreas Sahlbach
>
> current implementation from UriInfoImpl:
> {code}
>     public URI getRequestUri() {
>         String path = getAbsolutePathAsString();
>         String queries = (String)message.get(Message.QUERY_STRING);
>         if (queries != null) {
>             path += "?" + queries;
>         }
>         return URI.create(path);
>     }
> {code}
> This fails for URIs that have characters that have to be escaped as of rfc2396. 
> Examples: http://localhost:13080/services/rest/crypto/hash;algorithm=S{A/text/foo or http://localhost:13080/services/rest/crypto/hash;algorithm=S^A/text/foo
> fail with Exception during getRequestUri() due to { or ^ as part of the uri

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CXF-2677) UriInfoImpl.getRequestUri() fails on URLs that require escaping

Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834198#action_12834198 ] 

Sergey Beryozkin commented on CXF-2677:
---------------------------------------

This has been fixed in 2.2.7-SNAPSHOT, can you please try the SNAPSHOT to confirm ?

thanks, Sergey

> UriInfoImpl.getRequestUri() fails on URLs that require escaping
> ---------------------------------------------------------------
>
>                 Key: CXF-2677
>                 URL: https://issues.apache.org/jira/browse/CXF-2677
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 2.2.5, 2.2.6
>            Reporter: Andreas Sahlbach
>
> current implementation from UriInfoImpl:
> {code}
>     public URI getRequestUri() {
>         String path = getAbsolutePathAsString();
>         String queries = (String)message.get(Message.QUERY_STRING);
>         if (queries != null) {
>             path += "?" + queries;
>         }
>         return URI.create(path);
>     }
> {code}
> This fails for URIs that have characters that have to be escaped as of rfc2396. 
> Examples: http://localhost:13080/services/rest/crypto/hash;algorithm=S{A/text/foo or http://localhost:13080/services/rest/crypto/hash;algorithm=S^A/text/foo
> fail with Exception during getRequestUri() due to { or ^ as part of the uri

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.