You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/07/18 15:52:19 UTC

[GitHub] [tvm] Mousius commented on a diff in pull request #12119: [Target] Add target_parser to TargetKind

Mousius commented on code in PR #12119:
URL: https://github.com/apache/tvm/pull/12119#discussion_r923533606


##########
src/target/target.cc:
##########
@@ -52,7 +52,7 @@ class TargetInternal {
   static ObjectPtr<Object> FromString(const String& tag_or_config_or_target_str);
   static ObjectPtr<Object> FromConfigString(const String& config_str);
   static ObjectPtr<Object> FromRawString(const String& target_str);
-  static ObjectPtr<Object> FromConfig(std::unordered_map<String, ObjectRef> config);
+  static ObjectPtr<Object> FromConfig(Map<String, ObjectRef> config);

Review Comment:
   @kparzysz-quic not that I know of, I made an internal assumption here that `config` is another name for the JSON -  maybe @areusch or @junrushao1994 knows more?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org