You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/06/22 09:19:55 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #20350: [SPARK-23179][SQL] Support option to throw exception if overflow occurs

cloud-fan commented on a change in pull request #20350: [SPARK-23179][SQL] Support option to throw exception if overflow occurs
URL: https://github.com/apache/spark/pull/20350#discussion_r296439839
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -1441,6 +1441,16 @@ object SQLConf {
       .booleanConf
       .createWithDefault(true)
 
+  val DECIMAL_OPERATIONS_NULL_ON_OVERFLOW =
+    buildConf("spark.sql.decimalOperations.nullOnOverflow")
 
 Review comment:
   overflow can happen with non-decimal operations, do we need a new config?
   
   cc @JoshRosen 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org