You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/11/04 05:52:32 UTC

[GitHub] [incubator-hudi] yanghua commented on issue #991: Hudi Test Suite (Refactor)

yanghua commented on issue #991: Hudi Test Suite (Refactor) 
URL: https://github.com/apache/incubator-hudi/pull/991#issuecomment-549230923
 
 
   Hi @n3nash Thanks for refactoring the original PR. I left some comments some of them may need further discussion.
   
   - General:
     * Some class files missed License header, some of them have old(Uber -> Apache?) License information.
     * It would be better to rename the module name to reflect the real purpose, e.g. `hudi-end-to-end-test` or `hudi-test-suite` or something else?
   
   - Detailed:
   
   Please see inline comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services