[GitHub] [activemq-artemis] clebertsuconic commented on a diff in pull request #4029: ARTEMIS-3778 Streamline Expiration Reaping

[GitBox <gi...@apache.org>]

clebertsuconic commented on code in PR #4029:
URL: https://github.com/apache/activemq-artemis/pull/4029#discussion_r850409627


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java:
##########
@@ -1846,43 +1844,47 @@ private final class ExpiryReaper extends ActiveMQScheduledComponent {
          super(scheduledExecutorService, executor, checkPeriod, timeUnit, onDemand);
       }
 
-      volatile CountDownLatch inUseLatch;
+      volatile Iterator<Queue> iterator;

Review Comment:
   the very first version of this was using the executor of the queue.... which I later switched to use the same executor on the done method, so it does not need to be volatile..
   
   
   it's left over.. I forgot to remove it... thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org