[jira] [Comment Edited] (CALCITE-6574) Add ScopeMap

["James Starr (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-6574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881130#comment-17881130 ] 

James Starr edited comment on CALCITE-6574 at 9/12/24 4:42 PM:
---------------------------------------------------------------

[~julianhyde]I believe several of the helper functions and factory methods are called during scope population, so that solution would not work.  My initial thoughts would be to have a context that is propagated in place of the SqlValidatorImpl, the context would initially be populated with the initial helper functions and such.  Then just expand the functions that type validation to include it in their method signatures.  Then on a per method bases, the logic can inverted to in type validator or the scope populator depend on the context of the method.  However, what ever strategy is selected for breaking up the dependency of the scopes/namespaces on the validator impl, it would be easier or at least not more difficult if I continued with my initial purposed changes of splitting the the scope populating and type validation into explicit classes?


was (Author: jamesstarr):
[~julianhyde]I believe several of the helper functions and factory methods are called during scope population, so that solution would not work.  My initial thoughts would be to have a context that is propagated in place of the SqlValidatorImpl, the context would initially be populated with the initial helper functions and of such.  Then just expand the functions that type validation to include it in their method signatures.  Then on a per method bases, the logic can inverted to in type validator or the scope populator depend on the context of the method.  However, what ever strategy is selected for breaking up the dependency of the scopes/namespaces on the validator impl, it would be easier or at least not more difficult if I continued with my initial purposed changes of splitting the the scope populating and type validation into explicit classes?

> Add ScopeMap
> ------------
>
>                 Key: CALCITE-6574
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6574
>             Project: Calcite
>          Issue Type: Sub-task
>            Reporter: James Starr
>            Assignee: James Starr
>            Priority: Major
>              Labels: pull-request-available
>
> See parent description.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)