You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Ben McCann (JIRA)" <ji...@apache.org> on 2015/01/09 23:24:34 UTC

[jira] [Updated] (BCEL-186) Performance degradation with the UTF8 cache

     [ https://issues.apache.org/jira/browse/BCEL-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ben McCann updated BCEL-186:
----------------------------
    Attachment: patch2.diff

> Performance degradation with the UTF8 cache
> -------------------------------------------
>
>                 Key: BCEL-186
>                 URL: https://issues.apache.org/jira/browse/BCEL-186
>             Project: Commons BCEL
>          Issue Type: Bug
>    Affects Versions: 6.0
>            Reporter: Ben McCann
>             Fix For: 6.0
>
>         Attachments: patch2.diff, revert-ConstantUtf8-cache.diff
>
>
> I'd love to see 6.0 released.
> Here was the last vote:
> http://apache-commons.680414.n4.nabble.com/VOTE-Release-BCEL-6-0-based-on-RC3-td4667129.html
> Konstantin Kolinko reported some issues with caching that blocked the release:
> bq. I noted new methods that introduced caching into classfile.ConstantUtf8 class. BCEL_DONT_CACHE should at least have static setter, or a static setter for a cache instance / a factory class. RELEASE-NOTES.txt describes this change as [BCEL-163] Incorporate patch file from Findbugs which does not say much about this change. Actually this change introduced caching for ConstantUtf8 and ObjectType instances.
> Emmanuel Bourg did some investigation and testing and reported back:
> bq. If nobody object I'll remove this cache, the impact on the performance is too important to enable it by default, and the static state smells like a quick and dirty implementation. This feature could return as a pluggable cache if someone wants to provide a patch.
> garydgregory suggested adding a flush method to clear the cache in ObjectType



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)