You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Colin Patrick McCabe (JIRA)" <ji...@apache.org> on 2012/08/29 20:06:07 UTC
[jira] [Created] (HADOOP-8747) Syntax error on cmake version 2.6
patch 2 in JNIFlags.cmake
Colin Patrick McCabe created HADOOP-8747:
--------------------------------------------
Summary: Syntax error on cmake version 2.6 patch 2 in JNIFlags.cmake
Key: HADOOP-8747
URL: https://issues.apache.org/jira/browse/HADOOP-8747
Project: Hadoop Common
Issue Type: Bug
Components: native
Affects Versions: 2.2.0-alpha
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
On SUSE Linux Enterprise Server 11 SP1, "cmake version 2.6 patch 2" is installed.
It seems to have trouble parsing this "if" statement in JNIFlags.cmake:
{code}
IF((NOT JAVA_JVM_LIBRARY) OR (NOT JAVA_INCLUDE_PATH) OR (NOT JAVA_INCLUDE_PATH2))
{code}
We should rephrase this if statement so that it will work on all versions of cmake above or equal to 2.6.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8747) Syntax error on cmake version 2.6
patch 2 in JNIFlags.cmake
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444319#comment-13444319 ]
Hadoop QA commented on HADOOP-8747:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12542955/HADOOP-8747.001.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1381//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1381//console
This message is automatically generated.
> Syntax error on cmake version 2.6 patch 2 in JNIFlags.cmake
> -----------------------------------------------------------
>
> Key: HADOOP-8747
> URL: https://issues.apache.org/jira/browse/HADOOP-8747
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8747.001.patch
>
>
> On SUSE Linux Enterprise Server 11 SP1, "cmake version 2.6 patch 2" is installed.
> It seems to have trouble parsing this "if" statement in JNIFlags.cmake:
> {code}
> IF((NOT JAVA_JVM_LIBRARY) OR (NOT JAVA_INCLUDE_PATH) OR (NOT JAVA_INCLUDE_PATH2))
> {code}
> We should rephrase this if statement so that it will work on all versions of cmake above or equal to 2.6.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8747) Syntax error on cmake version 2.6
patch 2 in JNIFlags.cmake
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444516#comment-13444516 ]
Colin Patrick McCabe commented on HADOOP-8747:
----------------------------------------------
Also tested on centos 5.8 and ubuntu 12.04. Anyway, the really important issue here is the cmake version.
> Syntax error on cmake version 2.6 patch 2 in JNIFlags.cmake
> -----------------------------------------------------------
>
> Key: HADOOP-8747
> URL: https://issues.apache.org/jira/browse/HADOOP-8747
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8747.001.patch, HADOOP-8747.002.patch
>
>
> On SUSE Linux Enterprise Server 11 SP1, "cmake version 2.6 patch 2" is installed.
> It seems to have trouble parsing this "if" statement in JNIFlags.cmake:
> {code}
> IF((NOT JAVA_JVM_LIBRARY) OR (NOT JAVA_INCLUDE_PATH) OR (NOT JAVA_INCLUDE_PATH2))
> {code}
> We should rephrase this if statement so that it will work on all versions of cmake above or equal to 2.6.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8747) Syntax error on cmake version 2.6
patch 2 in JNIFlags.cmake
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444487#comment-13444487 ]
Todd Lipcon commented on HADOOP-8747:
-------------------------------------
Looks good. One suggestion: the strange empty IF clause makes this a bit hard to read. Can we do something like:
{code}
+ IF(JAVA_JVM_LIBRARY AND JAVA_INCLUDE_PATH AND JAVA_INCLUDE_PATH2)
MESSAGE("Using JAVA_JVM_LIBRARY=${JAVA_JVM_LIBRARY} JAVA_INCLUDE_PATH=${JAVA_INCLUDE_PATH} JAVA_INCLUDE_PATH2=${JAVA_INCLUDEPATH2}")
+ ELSE()
{code}
so that we don't have an empty block?
> Syntax error on cmake version 2.6 patch 2 in JNIFlags.cmake
> -----------------------------------------------------------
>
> Key: HADOOP-8747
> URL: https://issues.apache.org/jira/browse/HADOOP-8747
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8747.001.patch
>
>
> On SUSE Linux Enterprise Server 11 SP1, "cmake version 2.6 patch 2" is installed.
> It seems to have trouble parsing this "if" statement in JNIFlags.cmake:
> {code}
> IF((NOT JAVA_JVM_LIBRARY) OR (NOT JAVA_INCLUDE_PATH) OR (NOT JAVA_INCLUDE_PATH2))
> {code}
> We should rephrase this if statement so that it will work on all versions of cmake above or equal to 2.6.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8747) Syntax error on cmake version 2.6
patch 2 in JNIFlags.cmake
Posted by "Andy Isaacson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444317#comment-13444317 ]
Andy Isaacson commented on HADOOP-8747:
---------------------------------------
The failure we saw was:
{code}
[exec] CMake Error: Error in cmake code at
[exec] /var/lib/jenkins/workspace/CDH4-Hadoop-MR2-2.0.0/hadoop-common-project/hadoop-common/src/JNIFlags.cmake:106:
[exec] Parse error. Function missing ending ")". Instead found left paren with text "(".
{code}
> Syntax error on cmake version 2.6 patch 2 in JNIFlags.cmake
> -----------------------------------------------------------
>
> Key: HADOOP-8747
> URL: https://issues.apache.org/jira/browse/HADOOP-8747
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8747.001.patch
>
>
> On SUSE Linux Enterprise Server 11 SP1, "cmake version 2.6 patch 2" is installed.
> It seems to have trouble parsing this "if" statement in JNIFlags.cmake:
> {code}
> IF((NOT JAVA_JVM_LIBRARY) OR (NOT JAVA_INCLUDE_PATH) OR (NOT JAVA_INCLUDE_PATH2))
> {code}
> We should rephrase this if statement so that it will work on all versions of cmake above or equal to 2.6.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8747) Syntax error on cmake version 2.6
patch 2 in JNIFlags.cmake
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8747:
-----------------------------------------
Status: Patch Available (was: Open)
> Syntax error on cmake version 2.6 patch 2 in JNIFlags.cmake
> -----------------------------------------------------------
>
> Key: HADOOP-8747
> URL: https://issues.apache.org/jira/browse/HADOOP-8747
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8747.001.patch
>
>
> On SUSE Linux Enterprise Server 11 SP1, "cmake version 2.6 patch 2" is installed.
> It seems to have trouble parsing this "if" statement in JNIFlags.cmake:
> {code}
> IF((NOT JAVA_JVM_LIBRARY) OR (NOT JAVA_INCLUDE_PATH) OR (NOT JAVA_INCLUDE_PATH2))
> {code}
> We should rephrase this if statement so that it will work on all versions of cmake above or equal to 2.6.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8747) Syntax error on cmake version 2.6
patch 2 in JNIFlags.cmake
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444486#comment-13444486 ]
Alejandro Abdelnur commented on HADOOP-8747:
--------------------------------------------
+1. Colin, Before I commit, have you tested in other Linux distros as well?
> Syntax error on cmake version 2.6 patch 2 in JNIFlags.cmake
> -----------------------------------------------------------
>
> Key: HADOOP-8747
> URL: https://issues.apache.org/jira/browse/HADOOP-8747
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8747.001.patch
>
>
> On SUSE Linux Enterprise Server 11 SP1, "cmake version 2.6 patch 2" is installed.
> It seems to have trouble parsing this "if" statement in JNIFlags.cmake:
> {code}
> IF((NOT JAVA_JVM_LIBRARY) OR (NOT JAVA_INCLUDE_PATH) OR (NOT JAVA_INCLUDE_PATH2))
> {code}
> We should rephrase this if statement so that it will work on all versions of cmake above or equal to 2.6.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8747) Syntax error on cmake version 2.6
patch 2 in JNIFlags.cmake
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444536#comment-13444536 ]
Alejandro Abdelnur commented on HADOOP-8747:
--------------------------------------------
+1
> Syntax error on cmake version 2.6 patch 2 in JNIFlags.cmake
> -----------------------------------------------------------
>
> Key: HADOOP-8747
> URL: https://issues.apache.org/jira/browse/HADOOP-8747
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8747.001.patch, HADOOP-8747.002.patch
>
>
> On SUSE Linux Enterprise Server 11 SP1, "cmake version 2.6 patch 2" is installed.
> It seems to have trouble parsing this "if" statement in JNIFlags.cmake:
> {code}
> IF((NOT JAVA_JVM_LIBRARY) OR (NOT JAVA_INCLUDE_PATH) OR (NOT JAVA_INCLUDE_PATH2))
> {code}
> We should rephrase this if statement so that it will work on all versions of cmake above or equal to 2.6.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8747) Syntax error on cmake version 2.6
patch 2 in JNIFlags.cmake
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HADOOP-8747:
---------------------------------------
Resolution: Fixed
Fix Version/s: 2.2.0-alpha
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Thanks Colin. Committed to trunk and branch-2.
> Syntax error on cmake version 2.6 patch 2 in JNIFlags.cmake
> -----------------------------------------------------------
>
> Key: HADOOP-8747
> URL: https://issues.apache.org/jira/browse/HADOOP-8747
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Fix For: 2.2.0-alpha
>
> Attachments: HADOOP-8747.001.patch, HADOOP-8747.002.patch
>
>
> On SUSE Linux Enterprise Server 11 SP1, "cmake version 2.6 patch 2" is installed.
> It seems to have trouble parsing this "if" statement in JNIFlags.cmake:
> {code}
> IF((NOT JAVA_JVM_LIBRARY) OR (NOT JAVA_INCLUDE_PATH) OR (NOT JAVA_INCLUDE_PATH2))
> {code}
> We should rephrase this if statement so that it will work on all versions of cmake above or equal to 2.6.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8747) Syntax error on cmake version 2.6
patch 2 in JNIFlags.cmake
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444502#comment-13444502 ]
Colin Patrick McCabe commented on HADOOP-8747:
----------------------------------------------
@Alejandro: Jenkins builds on Debian, so that's another distro this patch has been tested on.
> Syntax error on cmake version 2.6 patch 2 in JNIFlags.cmake
> -----------------------------------------------------------
>
> Key: HADOOP-8747
> URL: https://issues.apache.org/jira/browse/HADOOP-8747
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8747.001.patch, HADOOP-8747.002.patch
>
>
> On SUSE Linux Enterprise Server 11 SP1, "cmake version 2.6 patch 2" is installed.
> It seems to have trouble parsing this "if" statement in JNIFlags.cmake:
> {code}
> IF((NOT JAVA_JVM_LIBRARY) OR (NOT JAVA_INCLUDE_PATH) OR (NOT JAVA_INCLUDE_PATH2))
> {code}
> We should rephrase this if statement so that it will work on all versions of cmake above or equal to 2.6.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8747) Syntax error on cmake version 2.6
patch 2 in JNIFlags.cmake
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444483#comment-13444483 ]
Colin Patrick McCabe commented on HADOOP-8747:
----------------------------------------------
I tested this on on SUSE Linux Enterprise Server 11 SP1, using "cmake version 2.6 patch 2."
Also tested on OpenSuSE 12.1 using cmake version 2.8.6.
> Syntax error on cmake version 2.6 patch 2 in JNIFlags.cmake
> -----------------------------------------------------------
>
> Key: HADOOP-8747
> URL: https://issues.apache.org/jira/browse/HADOOP-8747
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8747.001.patch
>
>
> On SUSE Linux Enterprise Server 11 SP1, "cmake version 2.6 patch 2" is installed.
> It seems to have trouble parsing this "if" statement in JNIFlags.cmake:
> {code}
> IF((NOT JAVA_JVM_LIBRARY) OR (NOT JAVA_INCLUDE_PATH) OR (NOT JAVA_INCLUDE_PATH2))
> {code}
> We should rephrase this if statement so that it will work on all versions of cmake above or equal to 2.6.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8747) Syntax error on cmake version 2.6
patch 2 in JNIFlags.cmake
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444524#comment-13444524 ]
Hadoop QA commented on HADOOP-8747:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12543001/HADOOP-8747.002.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1384//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1384//console
This message is automatically generated.
> Syntax error on cmake version 2.6 patch 2 in JNIFlags.cmake
> -----------------------------------------------------------
>
> Key: HADOOP-8747
> URL: https://issues.apache.org/jira/browse/HADOOP-8747
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8747.001.patch, HADOOP-8747.002.patch
>
>
> On SUSE Linux Enterprise Server 11 SP1, "cmake version 2.6 patch 2" is installed.
> It seems to have trouble parsing this "if" statement in JNIFlags.cmake:
> {code}
> IF((NOT JAVA_JVM_LIBRARY) OR (NOT JAVA_INCLUDE_PATH) OR (NOT JAVA_INCLUDE_PATH2))
> {code}
> We should rephrase this if statement so that it will work on all versions of cmake above or equal to 2.6.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HADOOP-8747) Syntax error on cmake version 2.6
patch 2 in JNIFlags.cmake
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy closed HADOOP-8747.
---------------------------------
> Syntax error on cmake version 2.6 patch 2 in JNIFlags.cmake
> -----------------------------------------------------------
>
> Key: HADOOP-8747
> URL: https://issues.apache.org/jira/browse/HADOOP-8747
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 2.0.2-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Fix For: 2.0.2-alpha
>
> Attachments: HADOOP-8747.001.patch, HADOOP-8747.002.patch
>
>
> On SUSE Linux Enterprise Server 11 SP1, "cmake version 2.6 patch 2" is installed.
> It seems to have trouble parsing this "if" statement in JNIFlags.cmake:
> {code}
> IF((NOT JAVA_JVM_LIBRARY) OR (NOT JAVA_INCLUDE_PATH) OR (NOT JAVA_INCLUDE_PATH2))
> {code}
> We should rephrase this if statement so that it will work on all versions of cmake above or equal to 2.6.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8747) Syntax error on cmake version 2.6
patch 2 in JNIFlags.cmake
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8747:
-----------------------------------------
Attachment: HADOOP-8747.001.patch
I think the handling of parentheses is at fault here. Here's a version of the if statement which doesn't use extra parentheses.
> Syntax error on cmake version 2.6 patch 2 in JNIFlags.cmake
> -----------------------------------------------------------
>
> Key: HADOOP-8747
> URL: https://issues.apache.org/jira/browse/HADOOP-8747
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8747.001.patch
>
>
> On SUSE Linux Enterprise Server 11 SP1, "cmake version 2.6 patch 2" is installed.
> It seems to have trouble parsing this "if" statement in JNIFlags.cmake:
> {code}
> IF((NOT JAVA_JVM_LIBRARY) OR (NOT JAVA_INCLUDE_PATH) OR (NOT JAVA_INCLUDE_PATH2))
> {code}
> We should rephrase this if statement so that it will work on all versions of cmake above or equal to 2.6.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8747) Syntax error on cmake version 2.6
patch 2 in JNIFlags.cmake
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8747:
-----------------------------------------
Attachment: HADOOP-8747.002.patch
* new version without empty 'if' block
> Syntax error on cmake version 2.6 patch 2 in JNIFlags.cmake
> -----------------------------------------------------------
>
> Key: HADOOP-8747
> URL: https://issues.apache.org/jira/browse/HADOOP-8747
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-8747.001.patch, HADOOP-8747.002.patch
>
>
> On SUSE Linux Enterprise Server 11 SP1, "cmake version 2.6 patch 2" is installed.
> It seems to have trouble parsing this "if" statement in JNIFlags.cmake:
> {code}
> IF((NOT JAVA_JVM_LIBRARY) OR (NOT JAVA_INCLUDE_PATH) OR (NOT JAVA_INCLUDE_PATH2))
> {code}
> We should rephrase this if statement so that it will work on all versions of cmake above or equal to 2.6.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira