You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "hailin0 (via GitHub)" <gi...@apache.org> on 2023/05/26 14:27:28 UTC
[GitHub] [seatunnel] hailin0 commented on a diff in pull request #4819: [Feature][SQL Transform]Add catalog support for SQL Transform plugin
hailin0 commented on code in PR #4819:
URL: https://github.com/apache/seatunnel/pull/4819#discussion_r1206870125
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf:
##########
@@ -37,11 +37,20 @@ source {
}
transform {
+ sql {
+ source_table_name = "customers_mysql_cdc"
+ query = """ select id, f_binary, f_blob, f_long_varbinary, f_longblob, f_tinyblob, f_varbinary, f_smallint, f_smallint_unsigned, f_mediumint,
+ f_mediumint_unsigned, f_int, f_int_unsigned, f_integer, f_integer_unsigned, f_bigint, f_bigint_unsigned, f_numeric, f_decimal,
+ f_float, f_double, f_double_precision, f_longtext, f_mediumtext, f_text, f_tinytext, f_varchar, f_date, f_datetime, f_timestamp,
+ f_bit1, f_bit64, f_char, f_enum, f_mediumblob, f_long_varchar, f_real, f_time, f_tinyint, f_tinyint_unsigned, f_json, f_year
+ from customers_mysql_cdc """
+ result_table_name = "trans_mysql_cdc"
+ }
Review Comment:
CDC contains INSERT/UPDATE_BEFORE/UPDATE_AFTER/DELETE operations so it is not suitable to use Transform
```suggestion
```
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf:
##########
@@ -37,11 +37,20 @@ source {
}
transform {
+ sql {
+ source_table_name = "customers_mysql_cdc"
+ query = """ select id, f_binary, f_blob, f_long_varbinary, f_longblob, f_tinyblob, f_varbinary, f_smallint, f_smallint_unsigned, f_mediumint,
+ f_mediumint_unsigned, f_int, f_int_unsigned, f_integer, f_integer_unsigned, f_bigint, f_bigint_unsigned, f_numeric, f_decimal,
+ f_float, f_double, f_double_precision, f_longtext, f_mediumtext, f_text, f_tinytext, f_varchar, f_date, f_datetime, f_timestamp,
+ f_bit1, f_bit64, f_char, f_enum, f_mediumblob, f_long_varchar, f_real, f_time, f_tinyint, f_tinyint_unsigned, f_json, f_year
+ from customers_mysql_cdc """
+ result_table_name = "trans_mysql_cdc"
+ }
}
sink {
jdbc {
- source_table_name = "customers_mysql_cdc"
+ source_table_name = "trans_mysql_cdc"
Review Comment:
revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org