You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Jack Cai (JIRA)" <ji...@apache.org> on 2009/01/12 04:44:59 UTC
[jira] Created: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Admin console should honor the priority of user agent's language setting
------------------------------------------------------------------------
Key: GERONIMO-4507
URL: https://issues.apache.org/jira/browse/GERONIMO-4507
Project: Geronimo
Issue Type: Improvement
Security Level: public (Regular issues)
Components: console
Affects Versions: 2.1.3, 2.2
Environment: All
Reporter: Jack Cai
Priority: Minor
See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by Gang Yin <yg...@gmail.com>.
Hi Kan
Currently for 2.1 branch, everything is all right, the patch you had
submitted in this JIRA is enough.
2009/3/18 Kan Ogawa (JIRA) <ji...@apache.org>
>
> [
> https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682934#action_12682934]
>
> Kan Ogawa commented on GERONIMO-4507:
> -------------------------------------
>
> Gang,
>
> To resolve this issue for V2.1, is it necessary to port both G-4484 and
> G-4517 patches at the same time?
>
> > Admin console should honor the priority of user agent's language setting
> > ------------------------------------------------------------------------
> >
> > Key: GERONIMO-4507
> > URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> > Project: Geronimo
> > Issue Type: Improvement
> > Security Level: public(Regular issues)
> > Components: console
> > Affects Versions: 2.1.3, 2.2
> > Environment: All
> > Reporter: Jack Cai
> > Assignee: Joe Bohn
> > Priority: Minor
> > Fix For: 2.1.4, 2.2
> >
> > Attachments: locale-priority.patch, locale-priority_fix.patch,
> locale-priority_fix2_v22.patch, locale-priority_V21.patch
> >
> >
> > See discussion:
> http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
Re: [jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by Gang Yin <yg...@gmail.com>.
yes, it's redundant code, I will remove it.
On Tue, Jan 13, 2009 at 11:30 PM, Jack Cai <gr...@gmail.com> wrote:
> It will. You can read the javadoc of ResourceBundle to see how it searches
> the bundles for a given locale.
>
> -Jack
>
>
> 2009/1/13 Gang Yin <yg...@gmail.com>
>
> Of course we can use both language and country parts, but now we only
>> provide property files like *.zh.properties rather than *.zh-CN.properties,
>> I'm not sure if locale like zh-CN will match *.zh.properties. I will test
>> it, and If getLanguage() is not necessary I will remove it.
>>
>>
>> On Tue, Jan 13, 2009 at 11:15 PM, Jack Cai (JIRA) <ji...@apache.org>wrote:
>>
>>>
>>> [
>>> https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663355#action_12663355]
>>>
>>> Jack Cai commented on GERONIMO-4507:
>>> ------------------------------------
>>>
>>> I don't quite understand why only the language part of the locale is used
>>> ...
>>>
>>> > Admin console should honor the priority of user agent's language
>>> setting
>>> >
>>> ------------------------------------------------------------------------
>>> >
>>> > Key: GERONIMO-4507
>>> > URL:
>>> https://issues.apache.org/jira/browse/GERONIMO-4507
>>> > Project: Geronimo
>>> > Issue Type: Improvement
>>> > Security Level: public(Regular issues)
>>> > Components: console
>>> > Affects Versions: 2.1.3, 2.2
>>> > Environment: All
>>> > Reporter: Jack Cai
>>> > Assignee: Donald Woods
>>> > Priority: Minor
>>> > Fix For: 2.2
>>> >
>>> > Attachments: locale-priority.patch, locale-priority_fix.patch
>>> >
>>> >
>>> > See discussion:
>>> http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>
>
Re: [jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting
Posted by Jack Cai <gr...@gmail.com>.
It will. You can read the javadoc of ResourceBundle to see how it searches
the bundles for a given locale.
-Jack
2009/1/13 Gang Yin <yg...@gmail.com>
> Of course we can use both language and country parts, but now we only
> provide property files like *.zh.properties rather than *.zh-CN.properties,
> I'm not sure if locale like zh-CN will match *.zh.properties. I will test
> it, and If getLanguage() is not necessary I will remove it.
>
>
> On Tue, Jan 13, 2009 at 11:15 PM, Jack Cai (JIRA) <ji...@apache.org> wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663355#action_12663355]
>>
>> Jack Cai commented on GERONIMO-4507:
>> ------------------------------------
>>
>> I don't quite understand why only the language part of the locale is used
>> ...
>>
>> > Admin console should honor the priority of user agent's language setting
>> > ------------------------------------------------------------------------
>> >
>> > Key: GERONIMO-4507
>> > URL:
>> https://issues.apache.org/jira/browse/GERONIMO-4507
>> > Project: Geronimo
>> > Issue Type: Improvement
>> > Security Level: public(Regular issues)
>> > Components: console
>> > Affects Versions: 2.1.3, 2.2
>> > Environment: All
>> > Reporter: Jack Cai
>> > Assignee: Donald Woods
>> > Priority: Minor
>> > Fix For: 2.2
>> >
>> > Attachments: locale-priority.patch, locale-priority_fix.patch
>> >
>> >
>> > See discussion:
>> http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
Re: [jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by Gang Yin <yg...@gmail.com>.
Of course we can use both language and country parts, but now we only
provide property files like *.zh.properties rather than *.zh-CN.properties,
I'm not sure if locale like zh-CN will match *.zh.properties. I will test
it, and If getLanguage() is not necessary I will remove it.
On Tue, Jan 13, 2009 at 11:15 PM, Jack Cai (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663355#action_12663355]
>
> Jack Cai commented on GERONIMO-4507:
> ------------------------------------
>
> I don't quite understand why only the language part of the locale is used
> ...
>
> > Admin console should honor the priority of user agent's language setting
> > ------------------------------------------------------------------------
> >
> > Key: GERONIMO-4507
> > URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> > Project: Geronimo
> > Issue Type: Improvement
> > Security Level: public(Regular issues)
> > Components: console
> > Affects Versions: 2.1.3, 2.2
> > Environment: All
> > Reporter: Jack Cai
> > Assignee: Donald Woods
> > Priority: Minor
> > Fix For: 2.2
> >
> > Attachments: locale-priority.patch, locale-priority_fix.patch
> >
> >
> > See discussion:
> http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Updated: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Yin updated GERONIMO-4507:
-------------------------------
Attachment: locale-priority_fix.patch
Add a new patch to delete duplicated property file
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Gang Yin
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "caiwenjing (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671783#action_12671783 ]
caiwenjing commented on GERONIMO-4507:
--------------------------------------
I give the priority of my language setting to English, but the admin console still displays chinese.
Environment: windows xp professional 2002 sp3 + IE7
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Kan Ogawa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682934#action_12682934 ]
Kan Ogawa commented on GERONIMO-4507:
-------------------------------------
Gang,
To resolve this issue for V2.1, is it necessary to port both G-4484 and G-4517 patches at the same time?
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Joe Bohn
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2_v22.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663175#action_12663175 ]
Gang Yin commented on GERONIMO-4507:
------------------------------------
I have no idea why all *.properties files are restored, It's weird because I already deleted them. I will attach a new patch to delete them again.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Gang Yin
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods resolved GERONIMO-4507.
------------------------------------
Resolution: Fixed
Applied patch from Kan Ogawa to branches/2.1 (2.1.4-SNAPSHOT) as Rev738979.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Yin updated GERONIMO-4507:
-------------------------------
Attachment: locale-priority_fix.patch
Modified version according to Jack's comment.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Kan Ogawa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Ogawa reopened GERONIMO-4507:
---------------------------------
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679211#action_12679211 ]
Donald Woods commented on GERONIMO-4507:
----------------------------------------
Is this for both 2.1 and 2.2?
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods reassigned GERONIMO-4507:
--------------------------------------
Assignee: Donald Woods (was: Gang Yin)
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods resolved GERONIMO-4507.
------------------------------------
Resolution: Fixed
Fix Version/s: 2.2
Patch from Gang Yin applied to trunk (2.2-SNAPSHOT) as Rev733885.
Please attach a patch for branches/2.1 if you would like to fix it there also, as the current patch includes properties for portlets that do not exist in 2.1.4-SNAPSHOT....
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Gang Yin
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods reopened GERONIMO-4507:
------------------------------------
Agree with Jarek that we don't want identical copies of English properties.... If we only include the *_en.properties, will that solve the issue or do we need both?
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Gang Yin
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Rex Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rex Wang closed GERONIMO-4507.
------------------------------
closing it.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Priority: Minor
> Fix For: 2.1.5, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2_v22.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Yin updated GERONIMO-4507:
-------------------------------
Attachment: (was: locale-priority_fix.patch)
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Gang Yin
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Yin updated GERONIMO-4507:
-------------------------------
Attachment: (was: locale-priority_fix.patch)
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663174#action_12663174 ]
Gang Yin commented on GERONIMO-4507:
------------------------------------
My patch is going to rename all *.properties to *_en.properties. Definitely we don't want to keep two copies of the same property file.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Gang Yin
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Jack Cai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663233#action_12663233 ]
Jack Cai commented on GERONIMO-4507:
------------------------------------
I'm not sure whether it's correct to only include the *_en.properties. If the browser's locale is set to something that's not in Geronimo's supported locale (en, zh), then there's no language to fall back?
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Gang Yin
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663237#action_12663237 ]
Jarek Gawor commented on GERONIMO-4507:
---------------------------------------
If the code is using standard ResourceBundles then as described in the JavaDoc we should provide the *.properties files. They are used as the last resort.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Gang Yin
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Yin updated GERONIMO-4507:
-------------------------------
Attachment: locale-priority_fix2.patch
It seems that the locale priority problem still exists when using IBM jdk, and this patch can fix the problem when using IBM jdk version 5.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663357#action_12663357 ]
Gang Yin commented on GERONIMO-4507:
------------------------------------
Updated patch on the basis of Rev734145
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662994#action_12662994 ]
Donald Woods commented on GERONIMO-4507:
----------------------------------------
Is the attached patch for 2.1 or 2.2?
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Gang Yin
> Priority: Minor
> Attachments: locale-priority.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679828#action_12679828 ]
Gang Yin commented on GERONIMO-4507:
------------------------------------
Thanks Joe, I will provide a patch for 2.1 branch soon.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Joe Bohn
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2_v22.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan resolved GERONIMO-4507.
----------------------------
Resolution: Fixed
This is fixed after adding duplicate message files.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Priority: Minor
> Fix For: 2.1.5, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2_v22.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Yin updated GERONIMO-4507:
-------------------------------
Attachment: (was: locale-priority_fix2.patch)
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Joe Bohn
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Yin updated GERONIMO-4507:
-------------------------------
Attachment: (was: locale-priority_fix.patch)
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682923#action_12682923 ]
Gang Yin commented on GERONIMO-4507:
------------------------------------
As Kan Ogawa hadn't finished porting G-4484(back-end message display and localization) and G-4517(front-end message display and localization) to branch 2.1,
so there is no need to provide a patch for branch 2.1.4 at all. Thanks Joe.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Joe Bohn
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2_v22.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Yin reassigned GERONIMO-4507:
----------------------------------
Assignee: Gang Yin
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Gang Yin
> Priority: Minor
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Yin updated GERONIMO-4507:
-------------------------------
Attachment: locale-priority_fix2.patch
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Joe Bohn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679229#action_12679229 ]
Joe Bohn commented on GERONIMO-4507:
------------------------------------
I suspect we need unique patches for trunk and branches/2.1. Also, please create patches from the root directory for the appropriate branch. Thank you.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Joe Bohn
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Yin updated GERONIMO-4507:
-------------------------------
Attachment: (was: locale-priority_fix2.patch)
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Yin reopened GERONIMO-4507:
--------------------------------
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Jack Cai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663355#action_12663355 ]
Jack Cai commented on GERONIMO-4507:
------------------------------------
I don't quite understand why only the language part of the locale is used ...
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods resolved GERONIMO-4507.
------------------------------------
Resolution: Fixed
Applied locale-priority_fix.patch from Gang Yin to trunk (2.2-SNAPSHOT) as Rev734161.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Yin updated GERONIMO-4507:
-------------------------------
Attachment: locale-priority_fix.patch
Hi, Donald,
This patch can fix the problem discussed above. All *_en.properties files are removed, they are not necessary anymore. All requests with locale of en will load default resource bundle.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Gang Yin
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663235#action_12663235 ]
Gang Yin commented on GERONIMO-4507:
------------------------------------
Hi, Jack. I had tested your concern and english will be displayed even if there is no *.properties.
Because the <fmt> tag in jsp pages which is responsible for localization will ignore the property file that has no language suffix, So I renamed all *.properties to *_en.properties.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Gang Yin
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Joe Bohn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679627#action_12679627 ]
Joe Bohn commented on GERONIMO-4507:
------------------------------------
Applied locale-priority_fix2_v22.patch to trunk in rev 750949. Please verify and provide a patch for branches/2.1.
Thanks!
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Joe Bohn
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2_v22.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Joe Bohn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bohn updated GERONIMO-4507:
-------------------------------
Fix Version/s: (was: 2.1.4)
2.1.5
Assignee: (was: Joe Bohn)
updated release version as it appears this won't make 2.1.4. Also removed myself as assigned so that others could investigate potential fixes.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Priority: Minor
> Fix For: 2.1.5, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2_v22.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Yin updated GERONIMO-4507:
-------------------------------
Attachment: locale-priority_fix.patch
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Joe Bohn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682733#action_12682733 ]
Joe Bohn commented on GERONIMO-4507:
------------------------------------
We need a patch for this in the next day or two or it will not make it into Geronimo 2.1.4.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Joe Bohn
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2_v22.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679467#action_12679467 ]
Gang Yin commented on GERONIMO-4507:
------------------------------------
BTW, geronimo-4507 and geronimo-4517 is patch ready for commit, please help to review and commit them, many thanks.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Joe Bohn
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2_v22.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (GERONIMO-4507) Admin console should
honor the priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679467#action_12679467 ]
yg edited comment on GERONIMO-4507 at 3/5/09 6:09 PM:
------------------------------------------------------------
BTW, geronimo-4550 and geronimo-4517 is patch ready for commit, please help to review and commit them, many thanks.
was (Author: yg):
BTW, geronimo-4507 and geronimo-4517 is patch ready for commit, please help to review and commit them, many thanks.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Joe Bohn
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2_v22.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Yin updated GERONIMO-4507:
-------------------------------
Attachment: locale-priority_fix2_v22.patch
Patch recreated from the root directory, this patch is for geronimo v2.2. Please help me to commit this patch, many thanks.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Joe Bohn
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2_v22.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Kan Ogawa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Ogawa updated GERONIMO-4507:
--------------------------------
Attachment: locale-priority_V21.patch
Donald,
I ported the patch for 2.1 version.
This patch is the almost same as 2.2 version.
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods reassigned GERONIMO-4507:
--------------------------------------
Assignee: Joe Bohn (was: Donald Woods)
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Joe Bohn
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_fix2.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Gang Yin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gang Yin updated GERONIMO-4507:
-------------------------------
Attachment: locale-priority.patch
problem solved
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Gang Yin
> Priority: Minor
> Attachments: locale-priority.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4507) Admin console should honor the
priority of user agent's language setting
Posted by "Kan Ogawa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Ogawa updated GERONIMO-4507:
--------------------------------
Fix Version/s: 2.1.4
> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4507
> URL: https://issues.apache.org/jira/browse/GERONIMO-4507
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.1.3, 2.2
> Environment: All
> Reporter: Jack Cai
> Assignee: Donald Woods
> Priority: Minor
> Fix For: 2.1.4, 2.2
>
> Attachments: locale-priority.patch, locale-priority_fix.patch, locale-priority_V21.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.