You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/14 05:06:39 UTC
[GitHub] [iceberg] ajantha-bhat opened a new pull request, #5761: Build: relocate httpclient5 dependency for runtime jars
ajantha-bhat opened a new pull request, #5761:
URL: https://github.com/apache/iceberg/pull/5761
REST API catalog introduces a dependency on httpclient5 and it is included without proper relocation.
So, relocate httpclient5 dependency for runtime jars to avoid conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pan3793 commented on pull request #5761: Build: relocate httpclient5 dependency for runtime jars
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #5761:
URL: https://github.com/apache/iceberg/pull/5761#issuecomment-1246241923
The change LGTM, which part relies on httpclient5? better to verify the runtime jar works manually, because relocation is not always safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko merged pull request #5761: Build: relocate httpclient5 dependency for runtime jars
Posted by GitBox <gi...@apache.org>.
Fokko merged PR #5761:
URL: https://github.com/apache/iceberg/pull/5761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #5761: Build: relocate httpclient5 dependency for runtime jars
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on PR #5761:
URL: https://github.com/apache/iceberg/pull/5761#issuecomment-1246293966
> The change LGTM, which part relies on httpclient5? better to verify the runtime jar works manually, because relocation is not always safe.
@pan3793: As mentioned, REST catalog uses this `httpclient5`. REST catalog needs a server implementation(which is not present in the iceberg repo). I believe some of the tabular guys can verify this.
cc: @nastra, @Fokko, @kbendick
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #5761: Build: relocate httpclient5 dependency for runtime jars
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on PR #5761:
URL: https://github.com/apache/iceberg/pull/5761#issuecomment-1246239606
@pan3793 : Please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org