You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@yetus.apache.org by GitBox <gi...@apache.org> on 2020/10/15 14:32:01 UTC
[GitHub] [yetus-test-patch-action] aw-was-here opened a new pull request #4: YETUS-992. Create and publish a github action (#3)
aw-was-here opened a new pull request #4:
URL: https://github.com/apache/yetus-test-patch-action/pull/4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus-test-patch-action] aw-was-here merged pull request #4: YETUS-992. Create and publish a github action (#3)
Posted by GitBox <gi...@apache.org>.
aw-was-here merged pull request #4:
URL: https://github.com/apache/yetus-test-patch-action/pull/4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus-test-patch-action] aw-was-here commented on pull request #4: YETUS-992. Create and publish a github action (#3)
Posted by GitBox <gi...@apache.org>.
aw-was-here commented on pull request #4:
URL: https://github.com/apache/yetus-test-patch-action/pull/4#issuecomment-709373836
NOTE: Requires https://github.com/apache/yetus/pull/160
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus-test-patch-action] ndimiduk commented on a change in pull request #4: YETUS-992. Create and publish a github action (#3)
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #4:
URL: https://github.com/apache/yetus-test-patch-action/pull/4#discussion_r505878178
##########
File path: action.yml
##########
@@ -86,6 +91,7 @@ runs:
- --excludes=${{ inputs.excludes }}
- --github-token=${{ inputs.githubtoken }}
- --html-report-file=${{ inputs.patchdir }}/report.html
+ - --ignore-unknown-options=true
Review comment:
Are `ignore-` and `report-unknown-options` mutually exclusive? Can test-patch infer one from the other?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus-test-patch-action] aw-was-here commented on pull request #4: YETUS-992. Create and publish a github action (#3)
Posted by GitBox <gi...@apache.org>.
aw-was-here commented on pull request #4:
URL: https://github.com/apache/yetus-test-patch-action/pull/4#issuecomment-709649859
Thanks for the approval @ndimiduk !
Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yetus-test-patch-action] aw-was-here commented on a change in pull request #4: YETUS-992. Create and publish a github action (#3)
Posted by GitBox <gi...@apache.org>.
aw-was-here commented on a change in pull request #4:
URL: https://github.com/apache/yetus-test-patch-action/pull/4#discussion_r505929021
##########
File path: action.yml
##########
@@ -86,6 +91,7 @@ runs:
- --excludes=${{ inputs.excludes }}
- --github-token=${{ inputs.githubtoken }}
- --html-report-file=${{ inputs.patchdir }}/report.html
+ - --ignore-unknown-options=true
Review comment:
They are not. `--ignore-unknown-options` allows you to pass options that test-patch may not know about. `--report-unknown-options` is whether or not test-patch tells you that unknown options got passed. I debated whether or not `--report` should auto trigger `--ignore` but felt for now to make `--report` working dependent upon `--ignore`. This is relatively easy to change later if we find out it doesn't work very well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org