[GitHub] [spark] HyukjinKwon commented on a change in pull request #26811: [SPARK-29600][SQL] array_contains built in function is not backward compatible in 3.0

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #26811: [SPARK-29600][SQL] array_contains built in function is not backward compatible in 3.0
URL: https://github.com/apache/spark/pull/26811#discussion_r355417542
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
 ##########
 @@ -1081,7 +1081,7 @@ case class ArrayContains(left: Expression, right: Expression)
     (left.dataType, right.dataType) match {
       case (_, NullType) => Seq.empty
       case (ArrayType(e1, hasNull), e2) =>
-        TypeCoercion.findTightestCommonType(e1, e2) match {
+        TypeCoercion.findWiderTypeForTwo(e1, e2) match {
 
 Review comment:
   This kind of things need a justification and migration guide update with tests. Which JIRA caused this issue?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org