You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by mtaylor <gi...@git.apache.org> on 2015/07/07 16:54:47 UTC
[GitHub] activemq-artemis pull request: Added Initial MQTT Protocol Support
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/62
Added Initial MQTT Protocol Support
Creates a new MQTT protocol module.
There is currently no support (at least tested support) for using MQTT to/from other protocols.
There are a number of outstanding items of work outlined in TODO/FIXME in the PR. These will be transferred to JIRA when/if the code is accepted.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtaylor/activemq-artemis initial-mqtt-support
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/62.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #62
----
commit e1ea2895cc404ddcb22f6cf99aa7c214f528711c
Author: Martyn Taylor <mt...@redhat.com>
Date: 2015-07-06T16:01:08Z
Added Initial MQTT Protocol Support
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Added Initial MQTT Protocol Support
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/62#issuecomment-119250451
Great Work!
Since this is a big task, I would like to have as many people reviewing this... Input is appreciated from anyone!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Added Initial MQTT Protocol Support
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/62#issuecomment-119635956
The only two big pieces I'm missing here are:
- examples (Make an example that could be used as a micro benchmark)
- Docs...
The examples can probably wait as you would need to do it under the new framework, on which case you would need to sync with @jbertram....
The docs... can you write something simple? We are about to release and I wouldn't want to go without docs for this. Mention this is early stage and we are welcoming feedback on the docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Added Initial MQTT Protocol Support
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/62#issuecomment-119972816
@clebertsuconic Sure, I'll ensure to contribute an example and documentation before then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Added Initial MQTT Protocol Support
Posted by andytaylor <gi...@git.apache.org>.
Github user andytaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/62#issuecomment-119890145
Ive reviewed the code with Martyn and I'm happy for this to be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Added Initial MQTT Protocol Support
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/62
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Added Initial MQTT Protocol Support
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/62#issuecomment-119966839
@mtaylor sure.. we can do this on a separate PR.
But given the progress we could release any time between 2 and 4 weeks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Added Initial MQTT Protocol Support
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/62#issuecomment-119972185
@clebertsuconic I'll aim to get documentation and an example done before then. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Added Initial MQTT Protocol Support
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/62#issuecomment-119872127
@clebertsuconic Am I able to follow up with some separate documentation rather than iterating over this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Added Initial MQTT Protocol Support
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/62#issuecomment-119891734
@clebertsuconic I've added some comments to the tests and uncommented tests with @ignore where possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---