You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by di...@apache.org on 2023/03/09 03:44:19 UTC
[rocketmq] branch develop updated: [ISSUE #6285] Polish the DLedgerControllerStateMachine log output to help troubleshoot
This is an automated email from the ASF dual-hosted git repository.
dinglei pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 244e8f915 [ISSUE #6285] Polish the DLedgerControllerStateMachine log output to help troubleshoot
244e8f915 is described below
commit 244e8f9158602aeb392fd570c6cf3a34a5d4eb6d
Author: rongtong <ji...@163.com>
AuthorDate: Thu Mar 9 11:44:13 2023 +0800
[ISSUE #6285] Polish the DLedgerControllerStateMachine log output to help troubleshoot
---
.../rocketmq/controller/impl/DLedgerControllerStateMachine.java | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/controller/src/main/java/org/apache/rocketmq/controller/impl/DLedgerControllerStateMachine.java b/controller/src/main/java/org/apache/rocketmq/controller/impl/DLedgerControllerStateMachine.java
index dde94e998..3d37c1eaf 100644
--- a/controller/src/main/java/org/apache/rocketmq/controller/impl/DLedgerControllerStateMachine.java
+++ b/controller/src/main/java/org/apache/rocketmq/controller/impl/DLedgerControllerStateMachine.java
@@ -48,6 +48,8 @@ public class DLedgerControllerStateMachine implements StateMachine {
@Override
public void onApply(CommittedEntryIterator iterator) {
int applyingSize = 0;
+ long firstApplyIndex = -1;
+ long lastApplyIndex = -1;
while (iterator.hasNext()) {
final DLedgerEntry entry = iterator.next();
final byte[] body = entry.getBody();
@@ -55,9 +57,11 @@ public class DLedgerControllerStateMachine implements StateMachine {
final EventMessage event = this.eventSerializer.deserialize(body);
this.replicasInfoManager.applyEvent(event);
}
+ firstApplyIndex = firstApplyIndex == -1 ? entry.getIndex() : firstApplyIndex;
+ lastApplyIndex = entry.getIndex();
applyingSize++;
}
- log.info("Apply {} events on controller {}", applyingSize, this.dLedgerId);
+ log.info("Apply {} events index from {} to {} on controller {}", applyingSize, firstApplyIndex, lastApplyIndex, this.dLedgerId);
}
@Override
@@ -69,7 +73,6 @@ public class DLedgerControllerStateMachine implements StateMachine {
return false;
}
-
@Override
public void onShutdown() {
}