[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9466: collect file info like mtime, length while listing files for free

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on code in PR #9466:
URL: https://github.com/apache/pinot/pull/9466#discussion_r980386228


##########
pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/FileInfo.java:
##########
@@ -0,0 +1,95 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.spi.filesystem;
+
+import com.google.common.base.Preconditions;
+import java.util.Optional;
+import org.apache.commons.lang3.StringUtils;
+
+
+/**
+ * FileInfo contains the file path and many optional file attributes like mtime, length etc.
+ */
+public class FileInfo {
+  private final String _filePath;
+  private final Long _lastModifiedTime;

Review Comment:
   Suggest making `_lastModifiedTime`, `_length` and `_isDirectory` primitive type to be consistent with other APIs. Essentially it should return the same info as calling each individual API



##########
pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/FileInfo.java:
##########
@@ -0,0 +1,95 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.spi.filesystem;
+
+import com.google.common.base.Preconditions;
+import java.util.Optional;
+import org.apache.commons.lang3.StringUtils;
+
+
+/**
+ * FileInfo contains the file path and many optional file attributes like mtime, length etc.
+ */
+public class FileInfo {
+  private final String _filePath;
+  private final Long _lastModifiedTime;
+  private final Long _length;
+  private final Boolean _isDirectory;
+
+  private FileInfo(String filePath, Long lastModifiedTime, Long length, Boolean isDirectory) {
+    _filePath = filePath;
+    _lastModifiedTime = lastModifiedTime;
+    _length = length;
+    _isDirectory = isDirectory;
+  }
+
+  public String getFilePath() {
+    return _filePath;
+  }
+
+  public Optional<Long> getLastModifiedTime() {
+    return Optional.ofNullable(_lastModifiedTime);
+  }
+
+  public Optional<Long> getLength() {
+    return Optional.ofNullable(_length);
+  }
+
+  public Optional<Boolean> isDirectory() {
+    return Optional.ofNullable(_isDirectory);
+  }
+
+  @Override
+  public String toString() {
+    return "FileInfo{" + "_filePath='" + _filePath + '\'' + ", _lastModifiedTime=" + _lastModifiedTime + ", _length="
+        + _length + ", _isDirectory=" + _isDirectory + '}';
+  }
+
+  public static class Builder {
+    private String _filePath;
+    private Long _lastModifiedTime;
+    private Long _length;
+    private Boolean _isDirectory;
+
+    public Builder setFilePath(String filePath) {
+      _filePath = filePath;
+      return this;
+    }
+
+    public Builder setLastModifiedTime(long lastModifiedTime) {
+      _lastModifiedTime = lastModifiedTime;
+      return this;
+    }
+
+    public Builder setLength(long length) {
+      _length = length;
+      return this;
+    }
+
+    public Builder setIsDirectory(boolean isDirectory) {
+      _isDirectory = isDirectory;
+      return this;
+    }
+
+    public FileInfo build() {
+      Preconditions.checkArgument(StringUtils.isNotEmpty(_filePath), "The filePath is required");
+      return new FileInfo(_filePath, _lastModifiedTime, _length, _isDirectory);
+    }
+  }
+}

Review Comment:
   (format) add empty line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org