You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by gu...@apache.org on 2019/06/21 19:42:50 UTC
[kafka] branch trunk updated: MINOR: Fix DistributedHerderTest
after adding reason to maybeLeaveGroup (#6982)
This is an automated email from the ASF dual-hosted git repository.
guozhang pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 11b25a1 MINOR: Fix DistributedHerderTest after adding reason to maybeLeaveGroup (#6982)
11b25a1 is described below
commit 11b25a13ee72e1c91facd0f94b888215f67d5a69
Author: Konstantine Karantasis <ko...@confluent.io>
AuthorDate: Fri Jun 21 12:42:34 2019 -0700
MINOR: Fix DistributedHerderTest after adding reason to maybeLeaveGroup (#6982)
Mocking of WorkerCoordinator was not precise after adding an argument (reason) to AbstractCoordinator#maybeLeaveGroup in KAFKA-8569:
Unit test case for DistributedHerderTest is now precise with respect to the expected argument and succeeds
Reviewers: Boyang Chen <bo...@confluent.io>, Guozhang Wang <wa...@gmail.com>
---
.../apache/kafka/connect/runtime/distributed/DistributedHerderTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java b/connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java
index f6cbfd6..bc40a61 100644
--- a/connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java
+++ b/connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java
@@ -1442,7 +1442,7 @@ public class DistributedHerderTest {
// Reading to end of log times out
configBackingStore.refresh(EasyMock.anyLong(), EasyMock.anyObject(TimeUnit.class));
EasyMock.expectLastCall().andThrow(new TimeoutException());
- member.maybeLeaveGroup("test join leader catch up fails");
+ member.maybeLeaveGroup(EasyMock.eq("taking too long to read the log"));
EasyMock.expectLastCall();
PowerMock.expectPrivate(herder, "backoff", DistributedConfig.WORKER_UNSYNC_BACKOFF_MS_DEFAULT);
member.requestRejoin();