You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/02/25 14:58:58 UTC
[GitHub] [beam] roger-mike opened a new pull request #16948: [BEAM-12777] Removed current docs version redirect
roger-mike opened a new pull request #16948:
URL: https://github.com/apache/beam/pull/16948
Removed the ```.htaccess``` redirect to a hardcoded URL with the current version of docs.
- ```beam.apache.org/releases/javadoc/current/``` stays as it is instead of redirecting to ```beam.apache.org/releases/javadoc/2.36.0/```
------------------------
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #16948: [BEAM-12777] Removed current docs version redirect
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #16948:
URL: https://github.com/apache/beam/pull/16948#issuecomment-1059845045
It looks like there a is problem.
current is pointing to 2.36.0 docs (https://beam.apache.org/releases/javadoc/current/)
but the current version is 2.37.0 (https://beam.apache.org/releases/javadoc/2.37.0/)
Maybe the release process was not updated? (/cc @TheNeuralBit )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #16948: [BEAM-12777] Removed current docs version redirect
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #16948:
URL: https://github.com/apache/beam/pull/16948#issuecomment-1060818379
Thanks for the ping Ahmet.
It looks like the release process was updated: https://github.com/apache/beam/pull/16327/files#diff-b47163558f49ed59a8a91deaa893c4bae776bfc9bd6249a64814ed7acfcc2621 but I didn't know about this and didn't run the script from head.
I put up https://github.com/apache/beam-site/pull/624 to address this. It replaces the duplicated directory with a symlink `current -> 2.37.0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #16948: [BEAM-12777] Removed current docs version redirect
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #16948:
URL: https://github.com/apache/beam/pull/16948#issuecomment-1051301719
We can merge. Manually verify. And if it fails revert it. If we do that, I would like to do it at a time when you can be available to check the results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #16948: [BEAM-12777] Removed current docs version redirect
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #16948:
URL: https://github.com/apache/beam/pull/16948#issuecomment-1054630410
I meant to ask in a new comment:
Today 4pm, pacific time?
tomorrow, 9am, pacific time?
would these work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #16948: [BEAM-12777] Removed current docs version redirect
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #16948:
URL: https://github.com/apache/beam/pull/16948#issuecomment-1051016270
@roger-mike - Is there a way to verify this is indeed working without the redirect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #16948: [BEAM-12777] Removed current docs version redirect
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #16948:
URL: https://github.com/apache/beam/pull/16948#issuecomment-1055657577
Merged. Changes should propagate to website.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] roger-mike commented on pull request #16948: [BEAM-12777] Removed current docs version redirect
Posted by GitBox <gi...@apache.org>.
roger-mike commented on pull request #16948:
URL: https://github.com/apache/beam/pull/16948#issuecomment-1054645884
>
9 AM PST works for me. I also sent you a message in the ASF slack, we can keep communicating there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] roger-mike commented on pull request #16948: [BEAM-12777] Removed current docs version redirect
Posted by GitBox <gi...@apache.org>.
roger-mike commented on pull request #16948:
URL: https://github.com/apache/beam/pull/16948#issuecomment-1054320656
> We can merge. Manually verify. And if it fails revert it. If we do that, I would like to do it at a time when you can be available to check the results.
That sounds good @aaltay, if you set a time I can make myself available 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] roger-mike edited a comment on pull request #16948: [BEAM-12777] Removed current docs version redirect
Posted by GitBox <gi...@apache.org>.
roger-mike edited a comment on pull request #16948:
URL: https://github.com/apache/beam/pull/16948#issuecomment-1054320656
Today 4pm, pacific time?
tomorrow, 9am, pacific time?
> We can merge. Manually verify. And if it fails revert it. If we do that, I would like to do it at a time when you can be available to check the results.
That sounds good @aaltay, if you set a time I can make myself available 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] roger-mike commented on pull request #16948: [BEAM-12777] Removed current docs version redirect
Posted by GitBox <gi...@apache.org>.
roger-mike commented on pull request #16948:
URL: https://github.com/apache/beam/pull/16948#issuecomment-1051105377
> @roger-mike - Is there a way to verify this is indeed working without the redirect?
I don't know how it can be tested, ```./gradlew :website:serveWebsite``` doesn't serve the javadocs or the pydocs. I found this https://htaccess.madewithlove.com/ in this PR https://github.com/apache/beam/pull/12945 where they tried to do the same. It tests that the ```.htaccess``` is redirecting correctly, but I'm not sure if this is useful to test that the URL is NOT redirecting 🤔.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay merged pull request #16948: [BEAM-12777] Removed current docs version redirect
Posted by GitBox <gi...@apache.org>.
aaltay merged pull request #16948:
URL: https://github.com/apache/beam/pull/16948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org