You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2014/10/16 04:42:43 UTC
Review Request 26796: Added --modules flag for tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26796/
-----------------------------------------------------------
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
Description
-------
This allows the user to specify the modules to loaded during tests. The
modules are made available to the master and slave subsystems.
Diffs
-----
src/tests/flags.hpp 189fad9a8125aa8f76a7abadc330a7f0ec7cc337
src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8
src/tests/module.hpp PRE-CREATION
src/tests/module.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26796/diff/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 26796: Added --modules flag for tests.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26796/#review56968
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26674, 26071, 26796]
All tests passed.
- Mesos ReviewBot
On Oct. 16, 2014, 4:57 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26796/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 4:57 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Till Toenshoff.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This allows the user to specify the modules to loaded during tests. The
> modules are made available to the master and slave subsystems.
>
>
> Diffs
> -----
>
> src/tests/flags.hpp 189fad9a8125aa8f76a7abadc330a7f0ec7cc337
> src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8
> src/tests/module.hpp PRE-CREATION
> src/tests/module.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26796/diff/
>
>
> Testing
> -------
>
> Tested by hand using the following commandline:
> ./bin/mesos-tests.sh --modules="/path/to/modules.json"
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 26796: Added --modules flag for tests.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26796/#review58040
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 22, 2014, 12:50 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26796/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 12:50 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Till Toenshoff.
>
>
> Bugs: MESOS-1864
> https://issues.apache.org/jira/browse/MESOS-1864
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This allows the user to specify the modules to loaded during tests. The
> modules are made available to the master and slave subsystems.
>
>
> Diffs
> -----
>
> src/tests/flags.hpp 189fad9a8125aa8f76a7abadc330a7f0ec7cc337
> src/tests/main.cpp fc83fd0bf2de67f7eacb951df51a1e5f4adc9eff
>
> Diff: https://reviews.apache.org/r/26796/diff/
>
>
> Testing
> -------
>
> Tested by hand using the following commandline:
> ./bin/mesos-tests.sh --modules="/path/to/modules.json"
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 26796: Added --modules flag for tests.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26796/
-----------------------------------------------------------
(Updated Oct. 22, 2014, 3:50 p.m.)
Review request for mesos, Niklas Nielsen and Till Toenshoff.
Bugs: MESOS-1864
https://issues.apache.org/jira/browse/MESOS-1864
Repository: mesos-git
Description
-------
This allows the user to specify the modules to loaded during tests. The
modules are made available to the master and slave subsystems.
Diffs (updated)
-----
src/tests/flags.hpp 189fad9a8125aa8f76a7abadc330a7f0ec7cc337
src/tests/main.cpp fc83fd0bf2de67f7eacb951df51a1e5f4adc9eff
Diff: https://reviews.apache.org/r/26796/diff/
Testing
-------
Tested by hand using the following commandline:
./bin/mesos-tests.sh --modules="/path/to/modules.json"
Thanks,
Kapil Arya
Re: Review Request 26796: Added --modules flag for tests.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26796/
-----------------------------------------------------------
(Updated Oct. 22, 2014, 4:04 a.m.)
Review request for mesos, Niklas Nielsen and Till Toenshoff.
Bugs: MESOS-1864
https://issues.apache.org/jira/browse/MESOS-1864
Repository: mesos-git
Description
-------
This allows the user to specify the modules to loaded during tests. The
modules are made available to the master and slave subsystems.
Diffs (updated)
-----
src/tests/flags.hpp 189fad9a8125aa8f76a7abadc330a7f0ec7cc337
src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8
Diff: https://reviews.apache.org/r/26796/diff/
Testing
-------
Tested by hand using the following commandline:
./bin/mesos-tests.sh --modules="/path/to/modules.json"
Thanks,
Kapil Arya
Re: Review Request 26796: Added --modules flag for tests.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26796/
-----------------------------------------------------------
(Updated Oct. 20, 2014, 11:47 p.m.)
Review request for mesos, Niklas Nielsen and Till Toenshoff.
Bugs: MESOS-1864
https://issues.apache.org/jira/browse/MESOS-1864
Repository: mesos-git
Description
-------
This allows the user to specify the modules to loaded during tests. The
modules are made available to the master and slave subsystems.
Diffs
-----
src/tests/flags.hpp 189fad9a8125aa8f76a7abadc330a7f0ec7cc337
src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8
Diff: https://reviews.apache.org/r/26796/diff/
Testing
-------
Tested by hand using the following commandline:
./bin/mesos-tests.sh --modules="/path/to/modules.json"
Thanks,
Kapil Arya
Re: Review Request 26796: Added --modules flag for tests.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26796/
-----------------------------------------------------------
(Updated Oct. 18, 2014, 3:16 p.m.)
Review request for mesos, Niklas Nielsen and Till Toenshoff.
Changes
-------
Rebased diff.
Repository: mesos-git
Description
-------
This allows the user to specify the modules to loaded during tests. The
modules are made available to the master and slave subsystems.
Diffs (updated)
-----
src/tests/flags.hpp 189fad9a8125aa8f76a7abadc330a7f0ec7cc337
src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8
Diff: https://reviews.apache.org/r/26796/diff/
Testing
-------
Tested by hand using the following commandline:
./bin/mesos-tests.sh --modules="/path/to/modules.json"
Thanks,
Kapil Arya
Re: Review Request 26796: Added --modules flag for tests.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26796/
-----------------------------------------------------------
(Updated Oct. 16, 2014, 3:23 p.m.)
Review request for mesos, Niklas Nielsen and Till Toenshoff.
Repository: mesos-git
Description
-------
This allows the user to specify the modules to loaded during tests. The
modules are made available to the master and slave subsystems.
Diffs (updated)
-----
src/tests/flags.hpp 189fad9a8125aa8f76a7abadc330a7f0ec7cc337
src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8
src/tests/module.hpp PRE-CREATION
src/tests/module.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26796/diff/
Testing
-------
Tested by hand using the following commandline:
./bin/mesos-tests.sh --modules="/path/to/modules.json"
Thanks,
Kapil Arya
Re: Review Request 26796: Added --modules flag for tests.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26796/
-----------------------------------------------------------
(Updated Oct. 16, 2014, 12:57 p.m.)
Review request for mesos, Niklas Nielsen and Till Toenshoff.
Repository: mesos-git
Description
-------
This allows the user to specify the modules to loaded during tests. The
modules are made available to the master and slave subsystems.
Diffs
-----
src/tests/flags.hpp 189fad9a8125aa8f76a7abadc330a7f0ec7cc337
src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8
src/tests/module.hpp PRE-CREATION
src/tests/module.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26796/diff/
Testing
-------
Tested by hand using the following commandline:
./bin/mesos-tests.sh --modules="/path/to/modules.json"
Thanks,
Kapil Arya
Re: Review Request 26796: Added --modules flag for tests.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26796/
-----------------------------------------------------------
(Updated Oct. 15, 2014, 11:48 p.m.)
Review request for mesos, Niklas Nielsen and Till Toenshoff.
Repository: mesos-git
Description
-------
This allows the user to specify the modules to loaded during tests. The
modules are made available to the master and slave subsystems.
Diffs
-----
src/tests/flags.hpp 189fad9a8125aa8f76a7abadc330a7f0ec7cc337
src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8
src/tests/module.hpp PRE-CREATION
src/tests/module.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26796/diff/
Testing
-------
Tested by hand using the following commandline:
./bin/mesos-tests.sh --modules="/path/to/modules.json"
Thanks,
Kapil Arya
Re: Review Request 26796: Added --modules flag for tests.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26796/
-----------------------------------------------------------
(Updated Oct. 15, 2014, 11:46 p.m.)
Review request for mesos, Niklas Nielsen and Till Toenshoff.
Repository: mesos-git
Description
-------
This allows the user to specify the modules to loaded during tests. The
modules are made available to the master and slave subsystems.
Diffs
-----
src/tests/flags.hpp 189fad9a8125aa8f76a7abadc330a7f0ec7cc337
src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8
src/tests/module.hpp PRE-CREATION
src/tests/module.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26796/diff/
Testing
-------
Tested by hand using the following commandline:
./bin/mesos-tests.sh --modules="/path/to/modules.json"
Thanks,
Kapil Arya
Re: Review Request 26796: Added --modules flag for tests.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26796/
-----------------------------------------------------------
(Updated Oct. 15, 2014, 11:45 p.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
Updated description.
Repository: mesos-git
Description
-------
This allows the user to specify the modules to loaded during tests. The
modules are made available to the master and slave subsystems.
Diffs
-----
src/tests/flags.hpp 189fad9a8125aa8f76a7abadc330a7f0ec7cc337
src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8
src/tests/module.hpp PRE-CREATION
src/tests/module.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26796/diff/
Testing (updated)
-------
Tested by hand using the following commandline:
./bin/mesos-tests.sh --modules="/path/to/modules.json"
Thanks,
Kapil Arya
Re: Review Request 26796: Added --modules flag for tests.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26796/
-----------------------------------------------------------
(Updated Oct. 15, 2014, 11:45 p.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
Bug fixes.
Repository: mesos-git
Description
-------
This allows the user to specify the modules to loaded during tests. The
modules are made available to the master and slave subsystems.
Diffs (updated)
-----
src/tests/flags.hpp 189fad9a8125aa8f76a7abadc330a7f0ec7cc337
src/tests/main.cpp 90a7ddcb5695d4c9a7760e18285548d99e7bcfa8
src/tests/module.hpp PRE-CREATION
src/tests/module.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26796/diff/
Testing (updated)
-------
Tested by hand using the following commandline:
./bin/mesos-tests.sh --modules="/path/to/modules.json" --isolation="org_apache_mesos_TestCpuIsolator"
Thanks,
Kapil Arya