You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2017/03/15 23:31:33 UTC
Review Request 57669: Ambari build fails at Files view
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57669/
-----------------------------------------------------------
Review request for Ambari, Sumit Mohanty and Yusaku Sako.
Bugs: AMBARI-20470
https://issues.apache.org/jira/browse/AMBARI-20470
Repository: ambari
Description
-------
Files view fails with below error:
/Users/Jaimin/vagrant/ambari-vagrant/centos6.4/gerrit/gerrit-ambari/contrib/views/files/src/main/resources/ui/node_modules/async-disk-cache/node_modules/username/index.js:2
const os = require('os');
^^^^^
Use of const in strict mode.
SyntaxError: Use of const in strict mode.
at Module._compile (module.js:439:25)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Object.<anonymous> (/Users/Jaimin/vagrant/ambari-vagrant/centos6.4/gerrit/gerrit-ambari/contrib/views/files/src/main/resources/ui/node_modules/async-disk-cache/index.js:24:16)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
Diffs
-----
contrib/views/files/src/main/resources/ui/package.json d15c5c9
Diff: https://reviews.apache.org/r/57669/diff/1/
Testing
-------
Verified that the patch fixes the issue and builds Files view project successfully. Also build other ambari ui projects and verified that others are not impacted with this issue
Thanks,
Jaimin Jetly
Re: Review Request 57669: Ambari build fails at Files view
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57669/#review169081
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On March 15, 2017, 11:31 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57669/
> -----------------------------------------------------------
>
> (Updated March 15, 2017, 11:31 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty and Yusaku Sako.
>
>
> Bugs: AMBARI-20470
> https://issues.apache.org/jira/browse/AMBARI-20470
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Files view fails with below error:
> /Users/Jaimin/vagrant/ambari-vagrant/centos6.4/gerrit/gerrit-ambari/contrib/views/files/src/main/resources/ui/node_modules/async-disk-cache/node_modules/username/index.js:2
> const os = require('os');
> ^^^^^
> Use of const in strict mode.
> SyntaxError: Use of const in strict mode.
> at Module._compile (module.js:439:25)
> at Object.Module._extensions..js (module.js:474:10)
> at Module.load (module.js:356:32)
> at Function.Module._load (module.js:312:12)
> at Module.require (module.js:364:17)
> at require (module.js:380:17)
> at Object.<anonymous> (/Users/Jaimin/vagrant/ambari-vagrant/centos6.4/gerrit/gerrit-ambari/contrib/views/files/src/main/resources/ui/node_modules/async-disk-cache/index.js:24:16)
> at Module._compile (module.js:456:26)
> at Object.Module._extensions..js (module.js:474:10)
> at Module.load (module.js:356:32)
>
>
> Diffs
> -----
>
> contrib/views/files/src/main/resources/ui/package.json d15c5c9
>
>
> Diff: https://reviews.apache.org/r/57669/diff/1/
>
>
> Testing
> -------
>
> Verified that the patch fixes the issue and builds Files view project successfully. Also build other ambari ui projects and verified that others are not impacted with this issue
>
>
> Thanks,
>
> Jaimin Jetly
>
>