[jira] [Commented] (IGNITE-5109) Refactoring for SparseDistributedMatrix

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995182#comment-15995182 ] 

ASF GitHub Bot commented on IGNITE-5109:
----------------------------------------

GitHub user ybabak opened a pull request:

    https://github.com/apache/ignite/pull/1903

    IGNITE-5109 Refactoring for SparseDistributedMatrix:

    Use one cache for all instances of SparseDistributedMatrix.
    
    Also added some tests and fixed get() and destroy() behavior for SparseDistributedMatrix.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-5109

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/1903.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1903
    
----
commit c42f68fb1bb574f5299364152de1655a2ef20ce6
Author: Yury Babak <yb...@gridgain.com>
Date:   2017-05-02T10:55:06Z

    IGNITE-5109 Refactoring for SparseDistributedMatrix:
      WIP

commit 5f24345b28c30a65f29100a4708ed36fa5199c49
Author: Yury Babak <yb...@gridgain.com>
Date:   2017-05-02T11:25:31Z

    IGNITE-5109 Refactoring for SparseDistributedMatrix:
      WIP

commit c4a44e1a9732456b57942257f89d2a45e16e6f94
Author: Yury Babak <yb...@gridgain.com>
Date:   2017-05-03T15:16:46Z

    IGNITE-5109 Refactoring for SparseDistributedMatrix:
      call get from remote node in case we don't have this entry in local node.

commit a9872a574ab3fb36f9695a0a2544dff67774282e
Author: Yury Babak <yb...@gridgain.com>
Date:   2017-05-03T15:48:08Z

    IGNITE-5109 Refactoring for SparseDistributedMatrix:
      fix SparseDistributedMatrix.destroy() behaviour
      added testCacheBehaviour

----


> Refactoring for SparseDistributedMatrix
> ---------------------------------------
>
>                 Key: IGNITE-5109
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5109
>             Project: Ignite
>          Issue Type: Bug
>          Components: ml
>            Reporter: Yury Babak
>            Assignee: Yury Babak
>             Fix For: 2.1
>
>
> According to [~agoncharuk] we should change logic of this matrix. Creating new cache each time when we create new matrix is really bad idea.
> So we must use one dedicated cache for ML matrices.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)