You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2014/05/15 01:33:38 UTC

[jclouds] Migrate InputSupplier callers to ByteSource (#370)

A future version of Guava will remove InputSupplier.
You can merge this Pull Request by running:

  git pull https://github.com/andrewgaul/jclouds remove-input-supplier

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/370

-- Commit Summary --

  * Migrate InputSupplier callers to ByteSource

-- File Changes --

    M compute/src/main/java/org/jclouds/ssh/SshKeys.java (13)
    M compute/src/test/java/org/jclouds/ssh/config/RsaSshKeyPairGeneratorTest.java (6)
    M core/src/main/java/org/jclouds/crypto/Pems.java (32)
    M core/src/main/java/org/jclouds/io/internal/BasePayloadSlicer.java (12)
    M core/src/main/java/org/jclouds/io/payloads/MultipartForm.java (15)
    M core/src/test/java/org/jclouds/crypto/PemsTest.java (25)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/370.patch
https://github.com/jclouds/jclouds/pull/370.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/370

Re: [jclouds] Migrate InputSupplier callers to ByteSource (#370)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-java-7-pull-requests #1276](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1276/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/370#issuecomment-43157797

Re: [jclouds] Migrate InputSupplier callers to ByteSource (#370)

Posted by Andrew Phillips <no...@github.com>.

Thanks for this, @andrewgaul! Code change itself looks good, just a small number of new [Checkstyle warnings](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1276/violations/) here..?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/370#issuecomment-43397485

Re: [jclouds] Migrate InputSupplier callers to ByteSource (#370)

Posted by Andrew Gaul <no...@github.com>.

Closed #370.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/370#event-122112983

Re: [jclouds] Migrate InputSupplier callers to ByteSource (#370)

Posted by Andrew Gaul <no...@github.com>.

Addressed in 62a68427488be3472fa1ccebb004d13f2b66018e.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/370#issuecomment-43400590

Re: [jclouds] Migrate InputSupplier callers to ByteSource (#370)

Posted by Andrew Phillips <no...@github.com>.

> Addressed in 62a6842.

Thanks, @andrewgaul!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/370#issuecomment-43446366

Re: [jclouds] Migrate InputSupplier callers to ByteSource (#370)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-pull-requests #806](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/806/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/370#issuecomment-43157534

Re: [jclouds] Migrate InputSupplier callers to ByteSource (#370)

Posted by Andrew Gaul <no...@github.com>.

Pushed to master.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/370#issuecomment-43393457

Re: [jclouds] Migrate InputSupplier callers to ByteSource (#370)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds #1100](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1100/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/370#issuecomment-43158144