You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "Al-assad (via GitHub)" <gi...@apache.org> on 2023/09/05 07:55:08 UTC
[GitHub] [incubator-streampark] Al-assad opened a new pull request, #3022: Optimize the validation logic of flinkDeploymentCR at PR#2966.
Al-assad opened a new pull request, #3022:
URL: https://github.com/apache/incubator-streampark/pull/3022
<!--
Thank you for contributing to StreamPark! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
## Contribution Checklist
- If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-streampark/issues).
- Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
-->
## What changes were proposed in this pull request
Optimize the validation logic of flinkDeploymentCR at PR#2966 including:
- Use structured Exception instead of RuntimeException.
- Use ZIO side effect instead of throwing exception to interrupt the process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] Al-assad commented on pull request #3022: Optimize the validation logic of flinkDeploymentCR at PR#2966.
Posted by "Al-assad (via GitHub)" <gi...@apache.org>.
Al-assad commented on PR #3022:
URL: https://github.com/apache/incubator-streampark/pull/3022#issuecomment-1706136723
cc @ChengJie1053, @wolfboys
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] Al-assad closed pull request #3022: Optimize the validation logic of flinkDeploymentCR at PR#2966.
Posted by "Al-assad (via GitHub)" <gi...@apache.org>.
Al-assad closed pull request #3022: Optimize the validation logic of flinkDeploymentCR at PR#2966.
URL: https://github.com/apache/incubator-streampark/pull/3022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] Al-assad closed pull request #3022: Optimize the validation logic of flinkDeploymentCR at PR#2966.
Posted by "Al-assad (via GitHub)" <gi...@apache.org>.
Al-assad closed pull request #3022: Optimize the validation logic of flinkDeploymentCR at PR#2966.
URL: https://github.com/apache/incubator-streampark/pull/3022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org