[GitHub] sandeep-krishnamurthy commented on a change in pull request #13721: [WIP] Fixes for trainer with update_on_kvstore=False

[GitBox <gi...@apache.org>]

sandeep-krishnamurthy commented on a change in pull request #13721: [WIP] Fixes for trainer with update_on_kvstore=False
URL: https://github.com/apache/incubator-mxnet/pull/13721#discussion_r244038191
 
 

 ##########
 File path: python/mxnet/gluon/trainer.py
 ##########
 @@ -28,6 +28,13 @@ class Trainer(object):
     """Applies an `Optimizer` on a set of Parameters. Trainer should
     be used together with `autograd`.
 
+    .. note::
+
+        `update_on_kvstore=False` is not supported in the following cases:
 
 Review comment:
   nit: Can we slightly reword for users to easily understand?
   something like - "Updates will always happen on kvstore, i.e., you cannot set update_on_kvstore=False, for the following cases:

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services