You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/04/29 11:37:49 UTC
Review Request 46825: Fully-typed all FlagsBase::add overloads.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Vinod Kone.
Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335
Repository: mesos
Description
-------
Fully-typed all FlagsBase::add overloads.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 66e16abe914e2a1ee7599bab857ff478b7ec20dc
3rdparty/libprocess/3rdparty/stout/tests/subcommand_tests.cpp 9213d6b9faec30b5be320ab37ca29c2406c964ac
Diff: https://reviews.apache.org/r/46825/diff/
Testing
-------
make check (OS X clang-trunk w/o optimizations)
The mesos tests suite do not execute at all with an optimizing clang-trunk since copying of the `map` inside `FlagsBase` reference random memory leading to `SEGFAULTs`. With these patches all of `stout-tests` and `libprocess-tests` can be executed, but some remaining failures persist in `mesos-tests` (their number is reduced though).
Thanks,
Benjamin Bannier
Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/#review131093
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46821, 46822, 46823, 46824, 46825]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 29, 2016, 9:37 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46825/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 9:37 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
>
>
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fully-typed all FlagsBase::add overloads.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 66e16abe914e2a1ee7599bab857ff478b7ec20dc
> 3rdparty/libprocess/3rdparty/stout/tests/subcommand_tests.cpp 9213d6b9faec30b5be320ab37ca29c2406c964ac
>
> Diff: https://reviews.apache.org/r/46825/diff/
>
>
> Testing
> -------
>
> make check (OS X clang-trunk w/o optimizations)
>
> The mesos tests suite do not execute at all with an optimizing clang-trunk since copying of the `map` inside `FlagsBase` reference random memory leading to `SEGFAULTs`. With these patches all of `stout-tests` and `libprocess-tests` can be executed, but some remaining failures persist in `mesos-tests` (their number is reduced though).
>
>
> Thanks,
>
> Benjamin Bannier
>
>