You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "pgjbz (via GitHub)" <gi...@apache.org> on 2023/06/28 21:34:05 UTC
[GitHub] [kafka] pgjbz opened a new pull request, #13928: KAFKA-15097: prevent server shutdown when source file not exists
pgjbz opened a new pull request, #13928:
URL: https://github.com/apache/kafka/pull/13928
catch NoSuchFileException on atomicMoveWithFallback this catch block will prevent throws NoSuchFileException and stop kafka server in Kraft Mode
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] xiaocairush commented on pull request #13928: KAFKA-15097: prevent server shutdown when source file not exists
Posted by "xiaocairush (via GitHub)" <gi...@apache.org>.
xiaocairush commented on PR #13928:
URL: https://github.com/apache/kafka/pull/13928#issuecomment-1612416149
Hi @pgjbz , could u kind please share which thread has deleted the log file? I'm a newbie for kafka source code and cannot find the root cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] pgjbz closed pull request #13928: KAFKA-15097: prevent server shutdown when source file not exists
Posted by "pgjbz (via GitHub)" <gi...@apache.org>.
pgjbz closed pull request #13928: KAFKA-15097: prevent server shutdown when source file not exists
URL: https://github.com/apache/kafka/pull/13928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #13928: KAFKA-15097: prevent server shutdown when source file not exists
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #13928:
URL: https://github.com/apache/kafka/pull/13928#issuecomment-1612559816
Hi @pgjbz
Thank you for your first contribution to Kafka. This utility method is used by multiple places in the code where NoSuchFileException is recoverable such as when moving index files. They are recoverable because index could be re-created. Hence, we cannot change the utility method itself.
I see from the Jira that you are specifically trying to address the movement of cleaner files. May I suggest changing the place in the code where we handle clean up to handle the scenario of NoSuchFileFound instead. You can start at this code:
https://github.com/apache/kafka/blob/482299c4e2c97315feea3db5d6bf0e5c2c8b8cc7/core/src/main/scala/kafka/log/LocalLog.scala#L839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] pgjbz closed pull request #13928: KAFKA-15097: prevent server shutdown when source file not exists
Posted by "pgjbz (via GitHub)" <gi...@apache.org>.
pgjbz closed pull request #13928: KAFKA-15097: prevent server shutdown when source file not exists
URL: https://github.com/apache/kafka/pull/13928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org