You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/06/01 06:26:36 UTC
[GitHub] [dubbo-go] sxllwx opened a new pull request #577: (WIP) kubernetes as registry enhance
sxllwx opened a new pull request #577:
URL: https://github.com/apache/dubbo-go/pull/577
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
1. Add multi namespace support for kubernetes registry
2. Switch from using List & Watch directly to using informer
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #512
**Special notes for your reviewer**:
Working In Progress, DONOT merge.
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] flycash merged pull request #577: kubernetes as registry enhance
Posted by GitBox <gi...@apache.org>.
flycash merged pull request #577:
URL: https://github.com/apache/dubbo-go/pull/577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #577: (WIP) kubernetes as registry enhance
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #577:
URL: https://github.com/apache/dubbo-go/pull/577#issuecomment-636640067
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=h1) Report
> Merging [#577](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #577 +/- ##
===========================================
- Coverage 66.43% 66.29% -0.14%
===========================================
Files 184 184
Lines 9712 9712
===========================================
- Hits 6452 6439 -13
- Misses 2620 2630 +10
- Partials 640 643 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `58.36% <ø> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.24% <0.00%> (+0.94%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=footer). Last update [4af26b9...667f4a0](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] Patrick0308 commented on a change in pull request #577: kubernetes as registry enhance
Posted by GitBox <gi...@apache.org>.
Patrick0308 commented on a change in pull request #577:
URL: https://github.com/apache/dubbo-go/pull/577#discussion_r435094396
##########
File path: remoting/zookeeper/client_test.go
##########
@@ -106,7 +106,7 @@ func TestCreateDelete(t *testing.T) {
assert.NoError(t, err)
err2 := z.Delete("/test1/test2/test3/test4")
assert.NoError(t, err2)
- //verifyEventOrder(t, event, []zk.EventType{zk.EventNodeCreated}, "event channel")
+ //verifyEventOrder(t, event, []zk.SourceObjectEventType{zk.EventNodeCreated}, "event channel")
Review comment:
Remove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #577: (WIP) kubernetes as registry enhance
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #577:
URL: https://github.com/apache/dubbo-go/pull/577#issuecomment-636640067
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=h1) Report
> Merging [#577](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #577 +/- ##
===========================================
- Coverage 66.43% 66.29% -0.14%
===========================================
Files 184 184
Lines 9712 9712
===========================================
- Hits 6452 6439 -13
- Misses 2620 2630 +10
- Partials 640 643 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `58.36% <ø> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.24% <0.00%> (+0.94%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=footer). Last update [4af26b9...f96091b](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #577: (WIP) kubernetes as registry enhance
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #577:
URL: https://github.com/apache/dubbo-go/pull/577#issuecomment-636640067
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=h1) Report
> Merging [#577](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #577 +/- ##
===========================================
- Coverage 66.43% 66.29% -0.14%
===========================================
Files 184 184
Lines 9712 9712
===========================================
- Hits 6452 6439 -13
- Misses 2620 2630 +10
- Partials 640 643 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `58.36% <ø> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.24% <0.00%> (+0.94%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=footer). Last update [4af26b9...7ab58c5](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #577: (WIP) kubernetes as registry enhance
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #577:
URL: https://github.com/apache/dubbo-go/pull/577#issuecomment-636640067
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=h1) Report
> Merging [#577](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `58.18%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #577 +/- ##
===========================================
- Coverage 66.43% 66.28% -0.15%
===========================================
Files 184 185 +1
Lines 9712 9770 +58
===========================================
+ Hits 6452 6476 +24
- Misses 2620 2655 +35
+ Partials 640 639 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `55.83% <55.83%> (ø)` | |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `76.25% <69.69%> (+17.88%)` | :arrow_up: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.89% <76.92%> (+0.59%)` | :arrow_up: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `67.30% <100.00%> (-3.85%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.33% <0.00%> (-3.74%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <0.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=footer). Last update [4af26b9...d07ebbc](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #577: (WIP) kubernetes as registry enhance
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #577:
URL: https://github.com/apache/dubbo-go/pull/577#issuecomment-636640067
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=h1) Report
> Merging [#577](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #577 +/- ##
===========================================
- Coverage 66.43% 66.29% -0.14%
===========================================
Files 184 184
Lines 9712 9712
===========================================
- Hits 6452 6439 -13
- Misses 2620 2630 +10
- Partials 640 643 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `58.36% <ø> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.24% <0.00%> (+0.94%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=footer). Last update [4af26b9...1669155](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on pull request #577: kubernetes as registry enhance
Posted by GitBox <gi...@apache.org>.
sxllwx commented on pull request #577:
URL: https://github.com/apache/dubbo-go/pull/577#issuecomment-638248340
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #577: (WIP) kubernetes as registry enhance
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #577:
URL: https://github.com/apache/dubbo-go/pull/577#issuecomment-636640067
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=h1) Report
> Merging [#577](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #577 +/- ##
===========================================
- Coverage 66.43% 66.29% -0.14%
===========================================
Files 184 184
Lines 9712 9712
===========================================
- Hits 6452 6439 -13
- Misses 2620 2630 +10
- Partials 640 643 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `58.36% <ø> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.24% <0.00%> (+0.94%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=footer). Last update [4af26b9...b98f88c](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx removed a comment on pull request #577: kubernetes as registry enhance
Posted by GitBox <gi...@apache.org>.
sxllwx removed a comment on pull request #577:
URL: https://github.com/apache/dubbo-go/pull/577#issuecomment-638248425
/assgin @hxmhlt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #577: (WIP) kubernetes as registry enhance
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #577:
URL: https://github.com/apache/dubbo-go/pull/577#issuecomment-636640067
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=h1) Report
> Merging [#577](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `58.18%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #577 +/- ##
===========================================
- Coverage 66.43% 66.28% -0.15%
===========================================
Files 184 185 +1
Lines 9712 9770 +58
===========================================
+ Hits 6452 6476 +24
- Misses 2620 2655 +35
+ Partials 640 639 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `55.83% <55.83%> (ø)` | |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `76.25% <69.69%> (+17.88%)` | :arrow_up: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.89% <76.92%> (+0.59%)` | :arrow_up: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `67.30% <100.00%> (-3.85%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.33% <0.00%> (-3.74%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <0.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=footer). Last update [4af26b9...16d4e8d](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on a change in pull request #577: kubernetes as registry enhance
Posted by GitBox <gi...@apache.org>.
sxllwx commented on a change in pull request #577:
URL: https://github.com/apache/dubbo-go/pull/577#discussion_r435101634
##########
File path: remoting/zookeeper/client_test.go
##########
@@ -106,7 +106,7 @@ func TestCreateDelete(t *testing.T) {
assert.NoError(t, err)
err2 := z.Delete("/test1/test2/test3/test4")
assert.NoError(t, err2)
- //verifyEventOrder(t, event, []zk.EventType{zk.EventNodeCreated}, "event channel")
+ //verifyEventOrder(t, event, []zk.SourceObjectEventType{zk.EventNodeCreated}, "event channel")
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #577: kubernetes as registry enhance
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #577:
URL: https://github.com/apache/dubbo-go/pull/577#issuecomment-636640067
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=h1) Report
> Merging [#577](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **increase** coverage by `0.47%`.
> The diff coverage is `58.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #577 +/- ##
===========================================
+ Coverage 66.43% 66.90% +0.47%
===========================================
Files 184 185 +1
Lines 9712 9749 +37
===========================================
+ Hits 6452 6523 +71
+ Misses 2620 2590 -30
+ Partials 640 636 -4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <ø> (-3.25%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `67.30% <50.00%> (-3.85%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `55.67% <55.67%> (ø)` | |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `76.25% <69.69%> (+17.88%)` | :arrow_up: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.89% <76.92%> (+0.59%)` | :arrow_up: |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `72.34% <100.00%> (ø)` | |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <0.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=footer). Last update [4af26b9...0f9a717](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #577: kubernetes as registry enhance
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #577:
URL: https://github.com/apache/dubbo-go/pull/577#issuecomment-636640067
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=h1) Report
> Merging [#577](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **increase** coverage by `0.25%`.
> The diff coverage is `58.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #577 +/- ##
===========================================
+ Coverage 66.43% 66.68% +0.25%
===========================================
Files 184 185 +1
Lines 9712 9749 +37
===========================================
+ Hits 6452 6501 +49
+ Misses 2620 2611 -9
+ Partials 640 637 -3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <ø> (-3.25%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `57.69% <50.00%> (-13.47%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `55.67% <55.67%> (ø)` | |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `76.25% <69.69%> (+17.88%)` | :arrow_up: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.89% <76.92%> (+0.59%)` | :arrow_up: |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `72.34% <100.00%> (ø)` | |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| ... and [21 more](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=footer). Last update [4af26b9...0f9a717](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #577: (WIP) kubernetes as registry enhance
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #577:
URL: https://github.com/apache/dubbo-go/pull/577#issuecomment-636640067
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=h1) Report
> Merging [#577](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `58.18%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #577 +/- ##
===========================================
- Coverage 66.43% 66.28% -0.15%
===========================================
Files 184 185 +1
Lines 9712 9770 +58
===========================================
+ Hits 6452 6476 +24
- Misses 2620 2655 +35
+ Partials 640 639 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `55.83% <55.83%> (ø)` | |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `76.25% <69.69%> (+17.88%)` | :arrow_up: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.89% <76.92%> (+0.59%)` | :arrow_up: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `67.30% <100.00%> (-3.85%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.33% <0.00%> (-3.74%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <0.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=footer). Last update [4af26b9...9607894](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #577: (WIP) kubernetes as registry enhance
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #577:
URL: https://github.com/apache/dubbo-go/pull/577#issuecomment-636640067
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=h1) Report
> Merging [#577](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #577 +/- ##
===========================================
- Coverage 66.43% 66.29% -0.14%
===========================================
Files 184 184
Lines 9712 9712
===========================================
- Hits 6452 6439 -13
- Misses 2620 2630 +10
- Partials 640 643 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `58.36% <ø> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.24% <0.00%> (+0.94%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=footer). Last update [4af26b9...16d4e8d](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #577: kubernetes as registry enhance
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #577:
URL: https://github.com/apache/dubbo-go/pull/577#issuecomment-636640067
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=h1) Report
> Merging [#577](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **increase** coverage by `0.47%`.
> The diff coverage is `58.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #577 +/- ##
===========================================
+ Coverage 66.43% 66.90% +0.47%
===========================================
Files 184 185 +1
Lines 9712 9749 +37
===========================================
+ Hits 6452 6523 +71
+ Misses 2620 2590 -30
+ Partials 640 636 -4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <ø> (-3.25%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `67.30% <50.00%> (-3.85%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `55.67% <55.67%> (ø)` | |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `76.25% <69.69%> (+17.88%)` | :arrow_up: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.89% <76.92%> (+0.59%)` | :arrow_up: |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `72.34% <100.00%> (ø)` | |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <0.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/577/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=footer). Last update [4af26b9...9607894](https://codecov.io/gh/apache/dubbo-go/pull/577?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org