You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Stefan Bodewig <bo...@apache.org> on 2011/08/17 08:06:52 UTC
[bcel] Backwards Incompatible Change to Visitor
Hi,
with svn revision 1158060 the bcel.generic.Visitor interface has become
package private, breaking the Gump builds of Xalan XSLTC,
commons-javaflow and likely other downstream code.
Has this change been intentional?
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [bcel] Backwards Incompatible Change to Visitor
Posted by Dave Brosius <db...@apache.org>.
Sebb is right... my mistake... apologies, and thanks for the fix.
dave
On 08/20/2011 09:15 PM, sebb wrote:
> On 17 August 2011 07:06, Stefan Bodewig<bo...@apache.org> wrote:
>> Hi,
>>
>> with svn revision 1158060 the bcel.generic.Visitor interface has become
>> package private, breaking the Gump builds of Xalan XSLTC,
>> commons-javaflow and likely other downstream code.
>>
>> Has this change been intentional?
> I don't think so.
>
> The rest of the commit just removes public from methods.
>
> I assume that was a mistake to change the interface itself, as it does
> not agree with the log message.
>
> I've reverted the change of interface visibilty.
>
>> Stefan
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [bcel] Backwards Incompatible Change to Visitor
Posted by sebb <se...@gmail.com>.
On 17 August 2011 07:06, Stefan Bodewig <bo...@apache.org> wrote:
> Hi,
>
> with svn revision 1158060 the bcel.generic.Visitor interface has become
> package private, breaking the Gump builds of Xalan XSLTC,
> commons-javaflow and likely other downstream code.
>
> Has this change been intentional?
I don't think so.
The rest of the commit just removes public from methods.
I assume that was a mistake to change the interface itself, as it does
not agree with the log message.
I've reverted the change of interface visibilty.
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [bcel] Backwards Incompatible Change to Visitor
Posted by Torsten Curdt <tc...@vafer.org>.
On Wed, Aug 17, 2011 at 8:06 AM, Stefan Bodewig <bo...@apache.org> wrote:
> Hi,
>
> with svn revision 1158060 the bcel.generic.Visitor interface has become
> package private, breaking the Gump builds of Xalan XSLTC,
> commons-javaflow and likely other downstream code.
Gump is so cool :)
cheers,
Torsten
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org