You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/30 13:22:38 UTC

[GitHub] [superset] GithubZhitao opened a new issue, #19910: build front failed

GithubZhitao opened a new issue, #19910:
URL: https://github.com/apache/superset/issues/19910

   
   #### How to reproduce the bug
   
   just run: sh js_build.sh 
   
   ### Expected results
   
   build success 
   
   ### Actual results
   
   ✖ 385 problems (56 errors, 329 warnings)
     13 errors and 0 warnings potentially fixable with the `--fix` option.
   
   #### Screenshots
   
   If applicable, add screenshots to help explain your problem.
   one kind of error segment 
   ```
   superset/superset-frontend/src/dashboard/components/menu/WithPopoverMenu.tsx
     51:5  error  defaultProp "children" defined for isRequired propType       react/default-props-match-prop-types
     52:5  error  defaultProp "disableClick" defined for isRequired propType   react/default-props-match-prop-types
     53:5  error  defaultProp "onChangeFocus" defined for isRequired propType  react/default-props-match-prop-types
     54:5  error  defaultProp "menuItems" defined for isRequired propType      react/default-props-match-prop-types
     55:5  error  defaultProp "isFocused" defined for isRequired propType      react/default-props-match-prop-types
     56:5  error  defaultProp "shouldFocus" defined for isRequired propType    react/default-props-match-prop-types
     60:5  error  defaultProp "style" defined for isRequired propType          react/default-props-match-prop-types
   ```
   another error segment 
   ```
     227:5   error    defaultProp "filterText" defined for isRequired propType            react/default-props-match-prop-types
     228:5   error    defaultProp "headerHeight" defined for isRequired propType          react/default-props-match-prop-types
     229:5   error    defaultProp "overscanColumnCount" defined for isRequired propType   react/default-props-match-prop-types
     230:5   error    defaultProp "overscanRowCount" defined for isRequired propType      react/default-props-match-prop-types
     231:5   error    defaultProp "rowHeight" defined for isRequired propType             react/default-props-match-prop-types
     232:5   error    defaultProp "striped" defined for isRequired propType               react/default-props-match-prop-types
     233:5   error    defaultProp "expandedColumns" defined for isRequired propType       react/default-props-match-prop-types
   ```
   
   ### Environment
   
   Mac OS 
   npm version 8.8.0
   node version v16.15.0
   
   ### Checklist
   
   I have run 
   ```
   npm run prettier 
   ```
   to fix some problems 
   ### Additional context
   
   I have add some config to .eslintrc.js to
   ```
     'file-progress/activate': 1,
           'jest-dom/prefer-checked': 'error',
           'jest-dom/prefer-enabled-disabled': 'error',
           'jest-dom/prefer-required': 'error',
           'jest-dom/prefer-to-have-attribute': 'error',
           'react/state-in-constructor' : 0,
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] build front failed [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #19910:
URL: https://github.com/apache/superset/issues/19910#issuecomment-1917632164

   We usually use `npm run build` to build the frontend bundles. Closing this as stale since it's been silent for a year and a half, and we're trying to steer toward a more actionable Issues backlog. If people are still encountering this in current versions (currently 3.x) please open a new Issue or a PR to address the problem.  
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] build front failed [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #19910: build front failed 
URL: https://github.com/apache/superset/issues/19910


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org