[jira] [Commented] (DRILL-7922) Add the profile import function

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354933#comment-17354933 ] 

ASF GitHub Bot commented on DRILL-7922:
---------------------------------------

Leon-WTF commented on a change in pull request #2225:
URL: https://github.com/apache/drill/pull/2225#discussion_r642895394



##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebUtils.java
##########
@@ -55,7 +55,10 @@
   public static String getCsrfTokenFromHttpRequest(HttpServletRequest request) {
     // No need to create a session if not present (i.e. if a user is logged in)
     HttpSession session = request.getSession(false);
-    return session == null ? "" : (String) session.getAttribute(WebServerConstants.CSRF_TOKEN);
+    String res = session == null ? "" :
+      (String) session.getAttribute(WebServerConstants.CSRF_TOKEN);
+    // In case session is created when authentication is disabled
+    return res == null ? "" : res;

Review comment:
       if drill.exec.security.user.auth.enabled=false, WebServerConstants.CSRF_TOKEN attribute will not be added into the session, after I created the session, this function will return null, which will cause exception when rendering the profile page




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add the profile import function
> -------------------------------
>
>                 Key: DRILL-7922
>                 URL: https://issues.apache.org/jira/browse/DRILL-7922
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: Cong Luo
>            Assignee: wtf
>            Priority: Major
>             Fix For: 1.19.0
>
>
> We can easy to read the profile metrics on the web console, but hard to review the profile of  other cluster (specified the users. although they can provide the profile json, but the file is not easy to readable).
> Since we can export the profile json via the console, So, We can also add the import function to quickly review the new cluster metrics.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)