[GitHub] [sling-org-apache-sling-feature-extension-apiregions] cziegeler commented on pull request #16: Add new enforce-on and since attributes for osgi configurations

[GitBox <gi...@apache.org>]

cziegeler commented on pull request #16:
URL: https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/16#issuecomment-872374181


   @angulito Thanks for your patch. It looks very good. I think there is a minor issue: not all configuration validation errors/warns are generated inside ConfigurationValidator. Some of them are generated from the FeatureValidator - however FeatureValidator uses ConfigurationValidator.setResult. I think if you move the postfix logic to that method, you will catch all places and ensure that all warnings and errors have the postfix. Similar with PropertyValidator.setResult which might be called from ConfigurationValidator


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org