You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "felipecrv (via GitHub)" <gi...@apache.org> on 2023/05/10 14:24:13 UTC

[GitHub] [arrow] felipecrv opened a new pull request, #35533: MINOR: [C++] Add missing ARROW_EXPORT to IsNull impls

felipecrv opened a new pull request, #35533:
URL: https://github.com/apache/arrow/pull/35533

   ### Rationale for this change
   
   Fix Windows ARM64 CI builds. (Example https://github.com/apache/arrow/actions/runs/4918687806/jobs/8806728909)
   
   ### What changes are included in this PR?
   
   ARROW_EXPORT internal functions that are called from inlined functions like `IsNull` and `IsValid`.
   
   ### Are these changes tested?
   
   N/A.
   
   ### Are there any user-facing changes?
   
   More symbols are exported in the .dll.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #35533: MINOR: [C++] Add missing ARROW_EXPORT to IsNull impls

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #35533:
URL: https://github.com/apache/arrow/pull/35533#issuecomment-1542312119

   Looks like Github Actions is currently broken...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] felipecrv commented on pull request #35533: MINOR: [C++] Add missing ARROW_EXPORT to IsNull impls

Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on PR #35533:
URL: https://github.com/apache/arrow/pull/35533#issuecomment-1542428367

   > `ARROW_EXPORT` should only be useful in declarations, so I'm not sure why you're adding it in `data.cc`.
   
   I already had them in the header and got the wrong impression from the windows compiler errors. @mapleFU's fix really is the way to go -- with the `ARROW_FRIEND_EXPORT` -- that's the real missing export declaration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] felipecrv commented on pull request #35533: MINOR: [C++] Add missing ARROW_EXPORT to IsNull impls

Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on PR #35533:
URL: https://github.com/apache/arrow/pull/35533#issuecomment-1542305570

   @pitrou 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] mapleFU commented on pull request #35533: MINOR: [C++] Add missing ARROW_EXPORT to IsNull impls

Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #35533:
URL: https://github.com/apache/arrow/pull/35533#issuecomment-1542337097

   I've create an issue and submit a request for this: https://github.com/apache/arrow/pull/35527


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] felipecrv closed pull request #35533: MINOR: [C++] Add missing ARROW_EXPORT to IsNull impls

Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv closed pull request #35533: MINOR: [C++] Add missing ARROW_EXPORT to IsNull impls
URL: https://github.com/apache/arrow/pull/35533


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org