You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/04/26 15:24:39 UTC

Review Request 66815: Removed an unconditional .get() in DefaultExecutor.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66815/
-----------------------------------------------------------

Review request for mesos and Gilbert Song.


Bugs: MESOS-8797
    https://issues.apache.org/jira/browse/MESOS-8797


Repository: mesos


Description
-------

This would fail in some cases where the optional
message is `None`, e.g. when the container is in
killing state.


Diffs
-----

  src/launcher/default_executor.cpp ea0d425bb60e970f209f411632e1d486c279259b 


Diff: https://reviews.apache.org/r/66815/diff/1/


Testing
-------

`./src/mesos-tests --gtest_filter=MesosContainerizer/DefaultExecutorTest.TaskUsesExecutor/0 --gtest_repeat=500 --gtest_break_on_failure`


Thanks,

Benno Evers


Re: Review Request 66815: Removed an unconditional .get() in DefaultExecutor.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66815/#review202017
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66815]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 26, 2018, 3:24 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66815/
> -----------------------------------------------------------
> 
> (Updated April 26, 2018, 3:24 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8797
>     https://issues.apache.org/jira/browse/MESOS-8797
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This would fail in some cases where the optional
> message is `None`, e.g. when the container is in
> killing state.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp ea0d425bb60e970f209f411632e1d486c279259b 
> 
> 
> Diff: https://reviews.apache.org/r/66815/diff/1/
> 
> 
> Testing
> -------
> 
> `./src/mesos-tests --gtest_filter=MesosContainerizer/DefaultExecutorTest.TaskUsesExecutor/0 --gtest_repeat=500 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Re: Review Request 66815: Removed an unconditional .get() in DefaultExecutor.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66815/#review202013
-----------------------------------------------------------



PASS: Mesos patch 66815 was successfully built and tested.

Reviews applied: `['66815']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66815

- Mesos Reviewbot Windows


On April 26, 2018, 3:24 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66815/
> -----------------------------------------------------------
> 
> (Updated April 26, 2018, 3:24 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8797
>     https://issues.apache.org/jira/browse/MESOS-8797
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This would fail in some cases where the optional
> message is `None`, e.g. when the container is in
> killing state.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp ea0d425bb60e970f209f411632e1d486c279259b 
> 
> 
> Diff: https://reviews.apache.org/r/66815/diff/1/
> 
> 
> Testing
> -------
> 
> `./src/mesos-tests --gtest_filter=MesosContainerizer/DefaultExecutorTest.TaskUsesExecutor/0 --gtest_repeat=500 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Re: Review Request 66815: Removed an unconditional .get() in DefaultExecutor.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66815/#review211235
-----------------------------------------------------------



PASS: Mesos patch 66815 was successfully built and tested.

Reviews applied: `['66815']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2699/mesos-review-66815

- Mesos Reviewbot Windows


On Dec. 12, 2018, 1:33 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66815/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2018, 1:33 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8797
>     https://issues.apache.org/jira/browse/MESOS-8797
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This would fail in some cases where the optional
> message is `None`, e.g. when the container is in
> killing state.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp b89b0363d64b8dd8936a62b57803f0eff50bfc71 
> 
> 
> Diff: https://reviews.apache.org/r/66815/diff/2/
> 
> 
> Testing
> -------
> 
> `./src/mesos-tests --gtest_filter=MesosContainerizer/DefaultExecutorTest.TaskUsesExecutor/0 --gtest_repeat=500 --gtest_break_on_failure`
> 
> CI results (5046):
> ```
> Configuration Name                      Duration All Failed Skipped
> FLAG=Clang,label=mesos-ec2-ubuntu-16.04	18 min	3207	0	0
> FLAG=Plain,label=mesos-ec2-ubuntu-16.04	18 min	3207	0	0
> FLAG=CMake,label=mesos-ec2-ubuntu-16.04	19 min	3160	0	0
> FLAG=SSL,label=mac	9 min 48 sec	2702	0	0
> FLAG=SSL,label=mesos-ec2-ubuntu-16.04	18 min	3270	1	0
> FLAG=SSL,label=mesos-ec2-debian-8	20 min	3266	0	0
> FLAG=SSL,label=mesos-ec2-debian-9	20 min	3268	0	0
> FLAG=SSL,label=mesos-ec2-centos-7	20 min	3261	0	0
> FLAG=BUILD_ISOLATORS,label=mesos-ec2-ubuntu-16.04	5.5 sec	606	0	0
> FLAG=CMake,label=mesos-ec2-centos-7	21 min	3151	0	0
> FLAG=SSL,label=mesos-ec2-ubuntu-14.04	19 min	3263	0	0
> FLAG=Plain,label=mesos-ec2-centos-7	20 min	3198	0	0
> FLAG=SSL,label=mesos-ec2-centos-6	16 min	3173	0	0
> ```
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Re: Review Request 66815: Removed an unconditional .get() in DefaultExecutor.

Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66815/
-----------------------------------------------------------

(Updated Dec. 12, 2018, 1:33 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
-------

Rebased onto latest master, addressed comments.


Bugs: MESOS-8797
    https://issues.apache.org/jira/browse/MESOS-8797


Repository: mesos


Description
-------

This would fail in some cases where the optional
message is `None`, e.g. when the container is in
killing state.


Diffs (updated)
-----

  src/launcher/default_executor.cpp b89b0363d64b8dd8936a62b57803f0eff50bfc71 


Diff: https://reviews.apache.org/r/66815/diff/2/

Changes: https://reviews.apache.org/r/66815/diff/1-2/


Testing (updated)
-------

`./src/mesos-tests --gtest_filter=MesosContainerizer/DefaultExecutorTest.TaskUsesExecutor/0 --gtest_repeat=500 --gtest_break_on_failure`

CI results (5046):
```
Configuration Name                      Duration All Failed Skipped
FLAG=Clang,label=mesos-ec2-ubuntu-16.04	18 min	3207	0	0
FLAG=Plain,label=mesos-ec2-ubuntu-16.04	18 min	3207	0	0
FLAG=CMake,label=mesos-ec2-ubuntu-16.04	19 min	3160	0	0
FLAG=SSL,label=mac	9 min 48 sec	2702	0	0
FLAG=SSL,label=mesos-ec2-ubuntu-16.04	18 min	3270	1	0
FLAG=SSL,label=mesos-ec2-debian-8	20 min	3266	0	0
FLAG=SSL,label=mesos-ec2-debian-9	20 min	3268	0	0
FLAG=SSL,label=mesos-ec2-centos-7	20 min	3261	0	0
FLAG=BUILD_ISOLATORS,label=mesos-ec2-ubuntu-16.04	5.5 sec	606	0	0
FLAG=CMake,label=mesos-ec2-centos-7	21 min	3151	0	0
FLAG=SSL,label=mesos-ec2-ubuntu-14.04	19 min	3263	0	0
FLAG=Plain,label=mesos-ec2-centos-7	20 min	3198	0	0
FLAG=SSL,label=mesos-ec2-centos-6	16 min	3173	0	0
```


Thanks,

Benno Evers


Re: Review Request 66815: Removed an unconditional .get() in DefaultExecutor.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66815/#review211188
-----------------------------------------------------------


Fix it, then Ship it!





src/launcher/default_executor.cpp
Line 938 (original), 939-944 (patched)
<https://reviews.apache.org/r/66815/#comment296119>

    Can we make it a one-liner? For example, 
    ```
        LOG(INFO)
            << "Child container " << container->containerId << " of task '"
            << taskId << "' completed in state " << stringify(taskState) << (message.isSome() ? ": " + message.get() : "");
    ```


- Alexander Rukletsov


On April 26, 2018, 3:24 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66815/
> -----------------------------------------------------------
> 
> (Updated April 26, 2018, 3:24 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8797
>     https://issues.apache.org/jira/browse/MESOS-8797
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This would fail in some cases where the optional
> message is `None`, e.g. when the container is in
> killing state.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp ea0d425bb60e970f209f411632e1d486c279259b 
> 
> 
> Diff: https://reviews.apache.org/r/66815/diff/1/
> 
> 
> Testing
> -------
> 
> `./src/mesos-tests --gtest_filter=MesosContainerizer/DefaultExecutorTest.TaskUsesExecutor/0 --gtest_repeat=500 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>