You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "eugenegujing (via GitHub)" <gi...@apache.org> on 2026/08/30 02:52:39 UTC

[I] Remove unused computing-unit selection helpers and style [texera]

eugenegujing opened a new issue, #8119:
URL: https://github.com/apache/texera/issues/8119

   ### Task Summary
   
   The computing-unit selection component retains three presentation helpers that production code no longer calls:
   
   | Unused code | Current live behavior |
   | --- | --- |
   | `getButtonText` | The template directly renders the selected unit name or `Connect`. |
   | `getCpuUnit` | The metrics template uses `getCpuLimitUnit`. |
   | `getMemoryUnit` | The metrics template uses `getMemoryLimitUnit`. |
   
   Their only callers are assertions in `computing-unit-selection.component.spec.ts`, so those tests preserve APIs that the product does not use. The component stylesheet also contains `.button-content i.ant-dropdown-trigger`, but `nz-dropdown` applies `ant-dropdown-trigger` to the outer button rather than the inner down-arrow icon, so the selector cannot match the rendered DOM.
   
   ### Task Type
   
   - [x] Refactor / Cleanup
   - [ ] DevOps / Deployment / CI
   - [ ] Testing / QA
   - [ ] Documentation
   - [ ] Performance
   - [ ] Other


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Remove unused computing-unit selection helpers and style [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan closed issue #8119: Remove unused computing-unit selection helpers and style
URL: https://github.com/apache/texera/issues/8119


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org