[GitHub] [arrow-datafusion] andygrove commented on pull request #3950: Vendor Generated Protobuf Code (#3947)

[GitBox <gi...@apache.org>]

andygrove commented on PR #3950:
URL: https://github.com/apache/arrow-datafusion/pull/3950#issuecomment-1290826101

   I am ok with either approach, but I think I would prefer to check in the generated sources rather than have build.rs download protoc. It seems like this could be a security risk and also adds complexity. I don't want to try and support a user who hits some issue with protoc not working on their system, I am possibly just trying to avoid extra work here. :sweat_smile: 
   
   > formatters will create git conflicts
   
   We can configure rustfmt to ignore the generated files (https://rust-lang.github.io/rustfmt/?version=v1.5.1&search=#ignore). @tustvold would you be ok with adding that to this PR?
   
   > the proto files and the checked-in code can get out of sync
   
   We should have CI prevent that from happening. Would be good to include that in this PR if possible.
   
   > users might edit the generated code accidentally
   
   This is bound to happen, but the files are in a `generated` directory, so I think people will learn pretty quickly not to do this.
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org