You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "Shohou (via GitHub)" <gi...@apache.org> on 2023/03/10 10:59:01 UTC
[GitHub] [pulsar-helm-chart] Shohou opened a new issue, #350: PULSAR_MEM variable doesn't set limits for bookie
Shohou opened a new issue, #350:
URL: https://github.com/apache/pulsar-helm-chart/issues/350
**Describe the bug**
I found that changing `PULSAR_MEM` variable for bookkeeper which can be found in `values.yaml` file doesn't change memory params of bookie at least for pulsar v2.9.4
Some investigation shows that in version 2.6.x `bin/pulsar` script had this line
```
OPTS="$OPTS $PULSAR_EXTRA_OPTS $PULSAR_MEM $PULSAR_GC"
```
from version 2.7.x till 2.9.x it has this:
```
if [ $COMMAND == "bookie" ]; then
# Pass BOOKIE_EXTRA_OPTS option defined in bkenv.sh
OPTS="$OPTS $BOOKIE_EXTRA_OPTS"
else
OPTS="$OPTS $PULSAR_EXTRA_OPTS $PULSAR_MEM $PULSAR_GC"
fi
```
and versions 2.10.x - 2.11.x has this:
```
if [ $COMMAND == "bookie" ]; then
# Pass BOOKIE_EXTRA_OPTS option defined in bkenv.sh
OPTS="$OPTS $BOOKIE_MEM $BOOKIE_GC $BOOKIE_GC_LOG $BOOKIE_EXTRA_OPTS"
else
OPTS="$OPTS $PULSAR_MEM $PULSAR_GC $PULSAR_GC_LOG $PULSAR_EXTRA_OPTS"
fi
```
I think it could be changed to BOOKIE_MEM with some comment about earlier versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] PULSAR_MEM variable doesn't set limits for bookie [pulsar-helm-chart]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on issue #350:
URL: https://github.com/apache/pulsar-helm-chart/issues/350#issuecomment-1912726836
`PULSAR_MEM` has been supported for a very long time as a fallback. There's no need to do anything. Old version of Pulsar aren't supported anyways. There are severe known security issues and that's a clear reason to upgrade to supported versions. Supported versions: https://pulsar.apache.org/contribute/release-policy/#supported-versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] PULSAR_MEM variable doesn't set limits for bookie [pulsar-helm-chart]
Posted by "Shohou (via GitHub)" <gi...@apache.org>.
Shohou commented on issue #350:
URL: https://github.com/apache/pulsar-helm-chart/issues/350#issuecomment-1916662443
@lhotari https://github.com/apache/pulsar-helm-chart/blob/4daf6d88a2417668fadfb6638145b13bbe08122c/charts/pulsar/values.yaml#L587 - if it's not supported then why it's still there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] PULSAR_MEM variable doesn't set limits for bookie [pulsar-helm-chart]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari closed issue #350: PULSAR_MEM variable doesn't set limits for bookie
URL: https://github.com/apache/pulsar-helm-chart/issues/350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org