You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/01 12:53:00 UTC
[jira] [Commented] (FLINK-6982) Replace guava dependencies
[ https://issues.apache.org/jira/browse/FLINK-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108839#comment-16108839 ]
ASF GitHub Bot commented on FLINK-6982:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4453
[FLINK-6982] [guava] Reduce guava dependency usages
## What is the purpose of the change
This PR removes unnecessary guava dependencies from several modules. Instead of just replacing these with flink-shaded-guava i figured we can just remove them before integrating the shaded guava dependency.
For the most part this PR is only touching tests.
## Brief change log
- remove unused guava dependency from `flink-scala` and `flink-streaming-scala`
- removed guava usages from flink-java
- removed guava usages from flink-tests
- removed guava usages from flink-yarn-tests
- removed guava usages from flink-yarn
## Verifying this change
This change is a trivial code cleanup, if it compiles and tests pass we're good.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6982_carve
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4453.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4453
----
commit cc6a0ba08a78479c5d3df18ab84063a769ff4845
Author: zentol <ch...@apache.org>
Date: 2017-06-13T15:01:24Z
[FLINK-6982] [guava] Reduce guava dependency usages
commit 60841fb1a521fc96e2b5ea1b061fd5c1b9df8c21
Author: zentol <ch...@apache.org>
Date: 2017-06-13T15:09:20Z
Remove flink-java guava dependency
commit 0ead8e004d6ffbaaf7d349526c7a6b2e4c02e4f6
Author: zentol <ch...@apache.org>
Date: 2017-06-13T15:14:10Z
Remove flink-tests guava dependency
commit af186b4458231ef6d212271615d5d94645e81282
Author: zentol <ch...@apache.org>
Date: 2017-06-13T15:14:21Z
Remove flink-yarn-tests guava dependency
commit 905e8166998b218d4c8351bb07cfddb3fc3888d7
Author: zentol <ch...@apache.org>
Date: 2017-06-13T15:14:29Z
Remove flink-yarn guava dependency
----
> Replace guava dependencies
> --------------------------
>
> Key: FLINK-6982
> URL: https://issues.apache.org/jira/browse/FLINK-6982
> Project: Flink
> Issue Type: Sub-task
> Components: Build System
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)