You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "malliaridis (via GitHub)" <gi...@apache.org> on 2025/01/04 11:50:56 UTC
[PR] Fix renovate.json to work with version catalogs [solr]
malliaridis opened a new pull request, #2936:
URL: https://github.com/apache/solr/pull/2936
# Description
With the version catalogs the solrbot stopped working, and we considered switching to dependabot (see https://github.com/apache/solr/pull/2880). Since the switch to dependabot is not straight-forward and was proven difficult, we may update solrbot to work with version catalogs again.
# Solution
This solution updates the renovate.json file, adds the version catalog file to the includePaths and executes the writeLocks task before updating licenses, as this step was also changed during the migration to version catalogs.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Fix renovate.json to work with version catalogs [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy merged PR #2936:
URL: https://github.com/apache/solr/pull/2936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Fix renovate.json to work with version catalogs [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #2936:
URL: https://github.com/apache/solr/pull/2936#issuecomment-2572674145
#2937 failed writeLocks:
```
Command failed: ./gradlew --console=plain --dependency-verification lenient -q :dependencies :solr:dependencies :solr:api:dependencies :solr:benchmark:dependencies :solr:core:dependencies :solr:cross-dc-manager:dependencies :solr:distribution:dependencies :solr:docker:dependencies :solr:documentation:dependencies :solr:example:dependencies :solr:modules:dependencies :solr:packaging:dependencies :solr:prometheus-exporter:dependencies :solr:server:dependencies :solr:solr-ref-guide:dependencies :solr:solrj:dependencies :solr:solrj-streaming:dependencies :solr:solrj-zookeeper:dependencies :solr:test-framework:dependencies :solr:webapp:dependencies :solr:modules:analysis-extras:dependencies :solr:modules:clustering:dependencies :solr:modules:cross-dc:dependencies :solr:modules:extraction:dependencies :solr:modules:gcs-repository:dependencies :solr:modules:hdfs:dependencies :solr:modules:jwt-auth:dependencies :solr:modules:langid:dependencies :solr:modules:llm:dependencies :solr:modules
:ltr:dependencies :solr:modules:opentelemetry:dependencies :solr:modules:s3-repository:dependencies :solr:modules:scripting:dependencies :solr:modules:sql:dependencies --update-locks org.apache.hadoop:hadoop-hdfs,org.apache.hadoop:hadoop-client-runtime,org.apache.hadoop:hadoop-client-minicluster,org.apache.hadoop:hadoop-client-api
FAILURE: Build failed with an exception.
* What went wrong:
Failed to notify task execution graph listener.
> Use the ':writeLocks' task to write the lock file, '--write-locks' along is not sufficient.
(snip)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Fix renovate.json to work with version catalogs [solr]
Posted by "malliaridis (via GitHub)" <gi...@apache.org>.
malliaridis commented on PR #2936:
URL: https://github.com/apache/solr/pull/2936#issuecomment-2573252585
Thanks for merging and testing it out @janhoy. I feared that much and I was looking for a way to test it before merge.
The issue is coming from the plugin limitation, for which I created a PR but haven't received any feedback yet (see https://github.com/carrotsearch/gradle-dependencychecks-plugin/pull/1).
The best option we probably have right now is to fix and finalize https://github.com/apache/solr/pull/2925. The PR removes completely the dependency-checks plugin and uses gradle without plugins for dependency locking. However, the PR is not ready yet, as there are some issues with errorprone, which we should fix before merging. Then, it should allow renovate to lock files with `--write-locks`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Fix renovate.json to work with version catalogs [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #2936:
URL: https://github.com/apache/solr/pull/2936#issuecomment-2572645379
Triggering a solrbot run to test...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Fix renovate.json to work with version catalogs [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #2936:
URL: https://github.com/apache/solr/pull/2936#issuecomment-2572733767
The error message comes from gradle-dependencyckecks-plugin: https://github.com/carrotsearch/gradle-dependencychecks-plugin/blob/3f2ad2884810e77ae34c084575e1e1df3863ec3d/src/main/java/com/carrotsearch/gradle/dependencychecks/DependencyChecksPlugin.java#L112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org