[GitHub] [skywalking] candyleer commented on a change in pull request #3120: Support servlet 2.5 for Jetty, Tomcat, SpringMvc

[GitBox <gi...@apache.org>]

candyleer commented on a change in pull request #3120: Support servlet 2.5 for Jetty,Tomcat,SpringMvc
URL: https://github.com/apache/skywalking/pull/3120#discussion_r305613434
 
 

 ##########
 File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/util/MethodUtil.java
 ##########
 @@ -42,4 +43,21 @@ public static String generateOperationName(Method method) {
         operationName.append(")");
         return operationName.toString();
     }
+
+
+    public static boolean isMethodExist(ClassLoader classLoader, String className, String methodName, Class<?>... parameterTypes) {
+        try {
+            Class<?> httpServletResponse = Class.forName(className, true, classLoader);
 
 Review comment:
   Yes,I forgot update

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services