You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "samkitdev17 (via GitHub)" <gi...@apache.org> on 2025/07/16 16:30:38 UTC
[PR] NIFI-14733: Fix Controller Service documentation rendering when @Tags… [nifi]
samkitdev17 opened a new pull request, #10096:
URL: https://github.com/apache/nifi/pull/10096
### Description
This PR resolves issue [NIFI-14733](https://issues.apache.org/jira/browse/NIFI-14733)
When a Controller Service does not have the `@Tags` annotation, the NiFi UI previously rendered a blank section or reused old cached content.
### Fix Implemented:
- Added fallback logic in `DtoFactory.java`:
- If `@Tags` is missing → display: **Tags: No tags available**
- Ensured clean behavior when switching between components.
### Testing
- Added a dummy ControllerService `DummyNoTagNoDescService` without annotations
- Performed local testing to confirm:
- Proper message is shown in the UI
- No caching bugs occur when switching components
- Verified both positive and negative scenarios
### Testing Steps:
1. Created a ControllerService without `@Tags`
2. Verified UI displays:
- Tags: No tags available
- Description: No description available
3. Verified normal services still render their tags/descriptions correctly
4. Ensured switching between services updates content correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14733: Fix Controller Service documentation rendering when @Tags… [nifi]
Posted by "samkitdev17 (via GitHub)" <gi...@apache.org>.
samkitdev17 commented on PR #10096:
URL: https://github.com/apache/nifi/pull/10096#issuecomment-3109341629
Thanks for pointing that out. I’ve restored the accidentally deleted `DtoFactory.java` file. The PR now only contains the intended doc fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14733: Fix Controller Service documentation rendering when @Tags… [nifi]
Posted by "samkitdev17 (via GitHub)" <gi...@apache.org>.
samkitdev17 commented on PR #10096:
URL: https://github.com/apache/nifi/pull/10096#issuecomment-3104055230
Addressed review feedback:
- Removed fallback message "No tags available" — now tags section is only shown if tags are defined
- Reverted unrelated change to `DtoFactory.java` capability description fallback
- Re-enabled FlowSynchronizationIT test — verified it still occasionally fails, but unrelated to this PR
Thanks again for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14733: Fix Controller Service documentation rendering when @Tags… [nifi]
Posted by "samkitdev17 (via GitHub)" <gi...@apache.org>.
samkitdev17 commented on PR #10096:
URL: https://github.com/apache/nifi/pull/10096#issuecomment-3080289048
⚠️ CI Note: A known flaky system test timed out:
FlowSynchronizationIT.testComponentsRecreatedOnRestart » Timeout
This failure is unrelated to the current changes in UI rendering logic and can be safely ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14733: Fix Controller Service documentation rendering when @Tags… [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #10096:
URL: https://github.com/apache/nifi/pull/10096#issuecomment-3105154461
@samkitdev17 Please review the changes and revert all unrelated modifications. The most recent push deleted `DtoFactory.java`, which is not correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14733: Fix Controller Service documentation rendering when @Tags… [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory merged PR #10096:
URL: https://github.com/apache/nifi/pull/10096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14733: Fix Controller Service documentation rendering when @Tags… [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #10096:
URL: https://github.com/apache/nifi/pull/10096#issuecomment-3104694135
Thanks @samkitdev17, it looks like the files have some unnecessary empty space changes, if you can revert that so the changes are scoped, this should be ready to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org