You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/14 07:35:33 UTC
[GitHub] [incubator-nuttx] liuguo09 opened a new pull request #781: esp32:
Remove the unecessary PREPROCESS call to fix build warning
liuguo09 opened a new pull request #781: esp32: Remove the unecessary PREPROCESS call to fix build warning
URL: https://github.com/apache/incubator-nuttx/pull/781
xtensa-esp32-elf-gcc: warning: /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32.template: linker input file unused because linking not done.
Signed-off-by: liuhaitao <li...@xiaomi.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #781:
esp32: Remove the unecessary PREPROCESS call to fix build warning
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #781: esp32: Remove the unecessary PREPROCESS call to fix build warning
URL: https://github.com/apache/incubator-nuttx/pull/781#discussion_r407959723
##########
File path: boards/xtensa/esp32/esp32-core/src/Makefile
##########
@@ -58,7 +58,6 @@ EXTRA_DISTCLEAN = $(call DELFILE, $(SCRIPTOUT))
include $(TOPDIR)/boards/Board.mk
$(SCRIPTOUT): $(SCRIPTIN) $(CONFIGFILE)
- # $(call PREPROCESS, $(SCRIPTIN), $@)
Review comment:
thank you for explanation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #781:
esp32: Remove the unecessary PREPROCESS call to fix build warning
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #781: esp32: Remove the unecessary PREPROCESS call to fix build warning
URL: https://github.com/apache/incubator-nuttx/pull/781#discussion_r407937055
##########
File path: boards/xtensa/esp32/esp32-core/src/Makefile
##########
@@ -58,7 +58,6 @@ EXTRA_DISTCLEAN = $(call DELFILE, $(SCRIPTOUT))
include $(TOPDIR)/boards/Board.mk
$(SCRIPTOUT): $(SCRIPTIN) $(CONFIGFILE)
- # $(call PREPROCESS, $(SCRIPTIN), $@)
Review comment:
how does removing a commented out line fix the warning?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request
#781: esp32: Remove the unecessary PREPROCESS call to fix build warning
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #781: esp32: Remove the unecessary PREPROCESS call to fix build warning
URL: https://github.com/apache/incubator-nuttx/pull/781#discussion_r407949425
##########
File path: boards/xtensa/esp32/esp32-core/src/Makefile
##########
@@ -58,7 +58,6 @@ EXTRA_DISTCLEAN = $(call DELFILE, $(SCRIPTOUT))
include $(TOPDIR)/boards/Board.mk
$(SCRIPTOUT): $(SCRIPTIN) $(CONFIGFILE)
- # $(call PREPROCESS, $(SCRIPTIN), $@)
Review comment:
Since PREPROCESS has two commands, and the second command is executed from the below log.
define PREPROCESS
@echo "CPP: $1->$2"
$(Q) $(CPP) $(CPPFLAGS) $($(strip $1)_CPPFLAGS) $1 -o $2
endef
make[2]: 进入目录“/home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/src”
\# @echo "CPP: /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32.template-> /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32_out.ld"
xtensa-esp32-elf-gcc -E -I. -isystem /home/haitao/code/apache/nuttx/include -Wno-cpp /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32.template -o /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32_out.ld
xtensa-esp32-elf-gcc: warning: /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32.template: linker input file unused because linking not done
xtensa-esp32-elf-gcc -isystem /home/haitao/code/apache/nuttx/include -C -P -x c -E /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32.template -o /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32_out.ld
make[2]: 离开目录“/home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/src”
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request
#781: esp32: Remove the unecessary PREPROCESS call to fix build warning
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #781: esp32: Remove the unecessary PREPROCESS call to fix build warning
URL: https://github.com/apache/incubator-nuttx/pull/781#discussion_r407949425
##########
File path: boards/xtensa/esp32/esp32-core/src/Makefile
##########
@@ -58,7 +58,6 @@ EXTRA_DISTCLEAN = $(call DELFILE, $(SCRIPTOUT))
include $(TOPDIR)/boards/Board.mk
$(SCRIPTOUT): $(SCRIPTIN) $(CONFIGFILE)
- # $(call PREPROCESS, $(SCRIPTIN), $@)
Review comment:
Since PREPROCESS has two commands, and the second command is executed from the below log.
define PREPROCESS
@echo "CPP: $1->$2"
$(Q) $(CPP) $(CPPFLAGS) $($(strip $1)_CPPFLAGS) $1 -o $2
endef
make[2]: 进入目录“/home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/src”
# @echo "CPP: /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32.template-> /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32_out.ld"
xtensa-esp32-elf-gcc -E -I. -isystem /home/haitao/code/apache/nuttx/include -Wno-cpp /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32.template -o /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32_out.ld
xtensa-esp32-elf-gcc: warning: /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32.template: linker input file unused because linking not done
xtensa-esp32-elf-gcc -isystem /home/haitao/code/apache/nuttx/include -C -P -x c -E /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32.template -o /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32_out.ld
make[2]: 离开目录“/home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/src”
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request
#781: esp32: Remove the unecessary PREPROCESS call to fix build warning
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #781: esp32: Remove the unecessary PREPROCESS call to fix build warning
URL: https://github.com/apache/incubator-nuttx/pull/781#discussion_r407949425
##########
File path: boards/xtensa/esp32/esp32-core/src/Makefile
##########
@@ -58,7 +58,6 @@ EXTRA_DISTCLEAN = $(call DELFILE, $(SCRIPTOUT))
include $(TOPDIR)/boards/Board.mk
$(SCRIPTOUT): $(SCRIPTIN) $(CONFIGFILE)
- # $(call PREPROCESS, $(SCRIPTIN), $@)
Review comment:
make[2]: 进入目录“/home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/src”
# @echo "CPP: /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32.template-> /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32_out.ld"
xtensa-esp32-elf-gcc -E -I. -isystem /home/haitao/code/apache/nuttx/include -Wno-cpp /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32.template -o /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32_out.ld
xtensa-esp32-elf-gcc: warning: /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32.template: linker input file unused because linking not done
xtensa-esp32-elf-gcc -isystem /home/haitao/code/apache/nuttx/include -C -P -x c -E /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32.template -o /home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/scripts/esp32_out.ld
make[2]: 离开目录“/home/haitao/code/apache/nuttx/boards/xtensa/esp32/esp32-core/src”
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt merged pull request #781: esp32: Remove the
unecessary PREPROCESS call to fix build warning
Posted by GitBox <gi...@apache.org>.
yamt merged pull request #781: esp32: Remove the unecessary PREPROCESS call to fix build warning
URL: https://github.com/apache/incubator-nuttx/pull/781
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services