[GitHub] [iceberg] jackye1995 commented on a diff in pull request #5555: Add s3.acceleration-enbled flag to AwsProperties

[GitBox <gi...@apache.org>]

jackye1995 commented on code in PR #5555:
URL: https://github.com/apache/iceberg/pull/5555#discussion_r948155475


##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -183,10 +190,11 @@ public static <T extends SdkClientBuilder> void configureEndpoint(T builder, Str
   }
 
   public static S3Configuration s3Configuration(
-      Boolean pathStyleAccess, Boolean s3UseArnRegionEnabled) {
+      Boolean pathStyleAccess, Boolean s3UseArnRegionEnabled, Boolean s3AccelerationEnabled) {

Review Comment:
   somehow we marked this as public, which is definitely a miss. Let me enable CI first and see if it detects it as incompatible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org