You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2024/09/09 09:36:18 UTC
[PR] [MNG-8230] Rewrite CI friendly versions [maven]
gnodet opened a new pull request, #1710:
URL: https://github.com/apache/maven/pull/1710
JIRA issue: https://issues.apache.org/jira/browse/MNG-8230
Requires #1704 and #1702
- **[MNG-8249] Provide an annotation processor for DI**
- **[MNG-8232] Introduce ModelTransformer**
- **[MNG-8230] Rewrite CI friendly version support**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8230] Rewrite CI friendly versions [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #1710:
URL: https://github.com/apache/maven/pull/1710#issuecomment-2358160164
> This PR seems mixed with DI?
Yes, it requires a session scope which is not well supported by the sisu/di bridge. I'll rebase once #1722 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8230] Rewrite CI friendly versions [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #1710:
URL: https://github.com/apache/maven/pull/1710#issuecomment-2359464674
> IMO, the proper way of working for CFV is:
>
> * any placeholder can be used (OK)
> * as long it has value defined, but this part is NOT OK, at least I see no code that makes sure version is not left placeholder?
>
> Or I miss something?
This role is supposed to be hold by the `ModelValidator` ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8230] Rewrite CI friendly versions [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1710:
URL: https://github.com/apache/maven/pull/1710#issuecomment-2359131294
IMO, the proper way of working for CFV is:
* any placeholder can be used (OK)
* as long it has value defined, but this part is NOT OK, at least I see no code that makes sure version is not left placeholder?
Or I miss something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org