[jira] [Commented] (HDFS-5035) getFileLinkStatus and rename do not correctly check permissions of symlinks

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-5035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13720404#comment-13720404 ] 

Hadoop QA commented on HDFS-5035:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12594316/hdfs-5035-1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified test files.

      {color:red}-1 javac{color}.  The applied patch generated 1151 javac compiler warnings (more than the trunk's current 1150 warnings).

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4734//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/4734//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Javac warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/4734//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4734//console

This message is automatically generated.
                
> getFileLinkStatus and rename do not correctly check permissions of symlinks
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-5035
>                 URL: https://issues.apache.org/jira/browse/HDFS-5035
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0, 2.1.0-beta
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-5035-1.patch
>
>
> Operations like getFileLinkStatus and rename operate on symlinks, not symlink targets. However, permission checks right now are being done on the symlink target, resulting in wonky behavior.
> This is similar to HDFS-4765, which fixed the same problem for delete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira