[jira] Commented: (TUSCANY-3626) JCA_9016 SCAClientFactory test domain name issues

["ant elder (JIRA)" <de...@tuscany.apache.org>]

    [ https://issues.apache.org/jira/browse/TUSCANY-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890606#action_12890606 ] 

ant elder commented on TUSCANY-3626:
------------------------------------

A couple of other issues with this test:

- The expected output string in JCA_9016_TestCase includes several occurrences of "NoSuchDomainException" but Service1SCAClientImpl is doing toString on the exception so the string includes the package name so should be "org.oasisopen.sca.NoSuchDomainException". Might be better for Service1SCAClientImpl  to check that the exception really is a NoSuchDomainException instead of just returning toString on it which may end up also including the domain name in the returned string.

- where Service1SCAClientImpl is testing an actual invocation of a service it ends up calling Service1SCAClientImpl.operation1 which is the same method that is doing the tests so ends up in a recursive loop. SHould it be a different service, or operation, or at least the operation1 method checking what the input string is to see if its a test invocation or service invocation,


> JCA_9016 SCAClientFactory test domain name issues
> -------------------------------------------------
>
>                 Key: TUSCANY-3626
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-3626
>             Project: Tuscany
>          Issue Type: Bug
>          Components: OASIS Compliance - OASIS
>            Reporter: ant elder
>
> The OASIS conformance test JCA_9016 test various incantations of the SCAClientFactory.newInstance method but the Service1SCAClientImpl class does not have validDomainURI correctly set so the test fails.
> One problem is that the domain URIs are created in the constructor from properties but the property values don't get initialized until after the constructor has run.
> Another issue is going to be what is a valid domain name. Maybe the test could use the name of the domain that the test component is running in, which it should be able to get with ComponentContext.getURI which should return the absolute URI of the component in the SCA Domain so as the test can know the relative uri of the test component it can remove that to get the domain name. (this wont actually work in Tuscany yet as ComponentContext.getURI doesn't return the absolute URI, but we can fix that)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.