You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/06/23 20:45:30 UTC
[GitHub] [trafficserver] bneradt commented on a change in pull request #7986: Docs: Fix pre-formatting for ratelimit plugin
bneradt commented on a change in pull request #7986:
URL: https://github.com/apache/trafficserver/pull/7986#discussion_r657448908
##########
File path: doc/admin-guide/plugins/rate_limit.en.rst
##########
@@ -82,27 +82,27 @@ Examples
This example shows a simple rate limiting of `128` concurrently active client
transactions, with a maximum queue size of `256`. The default of HTTP status
-code `429` is used when queue is full.
+code `429` is used when queue is full. ::
Review comment:
Good improvement.
As a small tweak, can we put the `::` on a line by itself? That seems more common:
- https://raw.githubusercontent.com/apache/trafficserver/master/doc/admin-guide/configuration/transparent-proxy/router-inline.en.rst
- https://raw.githubusercontent.com/apache/trafficserver/master/doc/developer-guide/debugging/debug-builds.en.rst
To name a couple examples. Let me know if you had a reason to put the `::` at the end of the previous line that I'm not aware of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org