You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@aurora.apache.org by "John Sirois (JIRA)" <ji...@apache.org> on 2017/01/17 21:25:26 UTC

[jira] [Commented] (AURORA-1875) The thriftw compatibility thrift binary check is too loose

    [ https://issues.apache.org/jira/browse/AURORA-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826851#comment-15826851 ] 

John Sirois commented on AURORA-1875:
-------------------------------------

Forgot to check for js and html, 1 more RB needed.

> The thriftw compatibility thrift binary check is too loose
> ----------------------------------------------------------
>
>                 Key: AURORA-1875
>                 URL: https://issues.apache.org/jira/browse/AURORA-1875
>             Project: Aurora
>          Issue Type: Bug
>            Reporter: John Sirois
>            Assignee: John Sirois
>
> Right now the [check|https://github.com/apache/aurora/blob/master/build-support/thrift/thriftw#L31] is only for the proper version. We need to also check java and python codegen are both supported by the binary since we use both.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)