You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "hyunw9 (via GitHub)" <gi...@apache.org> on 2025/07/20 04:51:44 UTC

[PR] [ZEPPELIN-6250] Remove unused methods from SemanticVersion class [zeppelin]

hyunw9 opened a new pull request, #4991:
URL: https://github.com/apache/zeppelin/pull/4991

   ### What is this PR for?
   As @ParkGyeongTae mentioned, in `zeppelin-test/src/main/java/org/apache/zeppelin/test/SemanticVersion.java`, 
   Some methods related to version checks were found to be **unused** and could potentially introduce **unintended side effects**. I've removed them to streamline the code. These functionalities can be re-implemented if their specifications are required in the future.
    
   
   ### What type of PR is it?
   Refactoring
   
   ### Todos
   * [ ] - Remove unused methods
   
   ### What is the Jira issue?
   * Put link [here](https://issues.apache.org/jira/browse/ZEPPELIN-6250)
   
   ### How should this be tested?
   * Strongly recommended: add automated unit tests for any new or changed behavior
   * Outline any manual steps to test the PR here. 
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the license files need to update? - No
   * Is there breaking changes for older versions? - No
   * Does this needs documentation? - No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6250] Remove unused methods from SemanticVersion class [zeppelin]

Posted by "hyunw9 (via GitHub)" <gi...@apache.org>.
hyunw9 commented on PR #4991:
URL: https://github.com/apache/zeppelin/pull/4991#issuecomment-3095675164

   @Reamer It looks same and using better approach than me ! and also it already merged. So i will close this pull request ! 
   thanks for review :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6250] Remove unused methods from SemanticVersion class [zeppelin]

Posted by "hyunw9 (via GitHub)" <gi...@apache.org>.
hyunw9 closed pull request #4991: [ZEPPELIN-6250] Remove unused methods from SemanticVersion class
URL: https://github.com/apache/zeppelin/pull/4991


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6250] Remove unused methods from SemanticVersion class [zeppelin]

Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4991:
URL: https://github.com/apache/zeppelin/pull/4991#issuecomment-3095657104

   Please checkout https://github.com/apache/zeppelin/pull/4991, which does nearly the same.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org